cleanup(text): Remove hard-coded tts:extent namespace in TTML parser

Closes #2860 Backported to v2.5.x Change-Id: I89bf96fa6536032ae20e85ba062cfc788dafd2c9
shaka-project · Oct 1, 2020 · 3231561 · 3231561
1 parent 2dd59c5
commit 3231561
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/text/ttml_text_parser.js b/lib/text/ttml_text_parser.js
@@ -67,6 +67,7 @@ shaka.text.TtmlTextParser.prototype.parseMedia = function(data, time) {
   const TtmlTextParser = shaka.text.TtmlTextParser;
   const XmlUtils = shaka.util.XmlUtils;
   const ttpNs = TtmlTextParser.parameterNs_;
+  const ttsNs = TtmlTextParser.styleNs_;
   let str = shaka.util.StringUtils.fromUTF8(data);
   let ret = [];
   let parser = new DOMParser();
@@ -122,7 +123,7 @@ shaka.text.TtmlTextParser.prototype.parseMedia = function(data, time) {
           XmlUtils.getAttributeNS(tt, ttpNs, 'frameRateMultiplier');
       tickRate = XmlUtils.getAttributeNS(tt, ttpNs, 'tickRate');
       spaceStyle = tt.getAttribute('xml:space') || 'default';
-      extent = tt.getAttribute('tts:extent');
+      extent = XmlUtils.getAttributeNS(tt, ttsNs, 'extent');
     }
 
     if (spaceStyle != 'default' && spaceStyle != 'preserve') {
@@ -519,7 +520,7 @@ shaka.text.TtmlTextParser.parseCue_ = function(
  * @param {!Element} regionElement
  * @param {!Array.<!Element>} styles Defined in the top of tt  element and
  * used principally for images.
- * @param {string} globalExtent
+ * @param {?string} globalExtent
  * @return {shaka.text.CueRegion}
  * @private
  */