Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded tts:extent namespace in TTML parser #2860

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Remove hard-coded tts:extent namespace in TTML parser #2860

merged 2 commits into from
Sep 23, 2020

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 21, 2020

Related to #2756

@theodab theodab self-assigned this Sep 23, 2020
@shaka-bot
Copy link
Collaborator

Test Failure:

Generating Closure dependencies...
Linting JavaScript...
Linting CSS...
Linting HTML...

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Scanned 3 files, no errors found (45 ms).
Checking that the build files are complete...
Checking for common misspellings...
Checking correct usage of eslint-disable...
Checking the tests for type errors...
No changes detected, skipping. Use --force to override.
/var/lib/jenkins/workspace/Manual PR Test (local-tests)/lib/text/ttml_text_parser.js:126: ERROR - [JSC_TYPE_MISMATCH] actual parameter 3 of TtmlTextParser.parseCueRegion_ does not match formal parameter
found   : (null|string)
required: string
TtmlTextParser.parseCueRegion_(region, styles, extent);
^^^^^^

1 error(s), 0 warning(s), 94.5% typed
Build failed
END-BUILD: FAILURE
Build step 'Execute shell' marked build as failure

@avelad
Copy link
Member Author

avelad commented Sep 23, 2020

I'm going to fix it ...

@avelad
Copy link
Member Author

avelad commented Sep 23, 2020

Fixed!

@avelad avelad requested a review from theodab September 23, 2020 08:41
@theodab
Copy link
Contributor

theodab commented Sep 23, 2020

Hah, you fixed it faster than I could write my review.

@shaka-bot
Copy link
Collaborator

All tests passed!

@theodab theodab merged commit df22dda into shaka-project:master Sep 23, 2020
@theodab
Copy link
Contributor

theodab commented Sep 23, 2020

Thank you for your contributions!

@avelad avelad deleted the tts-extent branch September 23, 2020 10:12
matEhickey pushed a commit to matEhickey/shaka-player that referenced this pull request Sep 25, 2020
cleanup(text): Remove hard-coded tts:extent namespace in TTML parser
e56dd9e 
Closes shaka-project#2860
matEhickey pushed a commit to matEhickey/shaka-player that referenced this pull request Sep 25, 2020
cleanup(text): Remove hard-coded tts:extent namespace in TTML parser
586249c 
Closes shaka-project#2860
joeyparrish pushed a commit that referenced this pull request Sep 29, 2020
@joeyparrish
cleanup(text): Remove hard-coded tts:extent namespace in TTML parser
47e2b2e 
Closes #2860
joeyparrish pushed a commit that referenced this pull request Oct 1, 2020
@joeyparrish
cleanup(text): Remove hard-coded tts:extent namespace in TTML parser
3231561 
Closes #2860

Backported to v2.5.x

Change-Id: I89bf96fa6536032ae20e85ba062cfc788dafd2c9
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab Awaiting requested review from theodab

Assignees

@theodab theodab

Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab