-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange subtitles rendering #1584
Comments
This is sort of expected. What is happening is we are using video::cue-region {
background: transparent;
} However, both Chrome (https://crbug.com/884232) and Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=1491365) have bugs where you can't use CSS to fix this. Maybe we should just not use Also note that your cues are supposed to have a transparent background, but we don't support many TTML styles, so we ignore it and just use the default black background. I've filed #1585 to handle the odd positioning. |
Thanks for the tip, but will the changes between 2.3.7 and 2.4.4 around rendering be rolled back or fixed? |
I guess we can revert VTTRegion support until browsers fix their implementations. It is currently only doing something on Firefox anyway. Also note that even though #1585 is fixed, it won't fix your content. You use a non-spec-compliant namespace URI in your TTML files; I suggest you talk to your encoder about using the correct namespace URIs. That file uses |
Browser support is currently buggy and limited, so until they fix it, this removes VTTRegion support. Closes #1584 Backported to v2.4.x Change-Id: Ia5bb34dd3ea94737adcdd1d441201bb97b303f81
The removal of VTTRegion support was cherry-picked to v2.4.5. |
Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
2.4.4
Can you reproduce the issue with our latest release version?:
Yes
Can you reproduce the issue with the latest code from
master
?:I didn't test it
Are you using the demo app or your own custom app?:
demo
If custom app, can you reproduce the issue using our demo app?:
What browser and OS are you using?:
MacOS High Sierra / Firefox 62.0
What are the manifest and license server URIs?:
What did you do?
What did you expect to happen?
What actually happened?
The text was updated successfully, but these errors were encountered: