Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTML parser doesn't support namespaces #1585

Closed
TheModMaker opened this issue Sep 14, 2018 · 1 comment
Closed

TTML parser doesn't support namespaces #1585

TheModMaker opened this issue Sep 14, 2018 · 1 comment
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles component: TTML The issue involves TTML subtitles specifically status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@TheModMaker
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
v2.4.4
Can you reproduce the issue with our latest release version?:
Yes
Can you reproduce the issue with the latest code from master?:
Yes
Are you using the demo app or your own custom app?:
Demo app
If custom app, can you reproduce the issue using our demo app?:

What browser and OS are you using?:
Any
What are the manifest and license server URIs?:
https://d1chyo78gdexn4.cloudfront.net/vualto-demo/elephants-dream/elephants-dream_nodrm.ism/manifest.mpd

What did you do?
Play TTML asset that uses XML namespaces with different prefixes than normal.
What did you expect to happen?
Play text fine.
What actually happened?
Cannot find attributes since the TTML parser looks up by simple name instead of namespace-qualified.

Found while investigating #1584.

@TheModMaker TheModMaker added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically labels Sep 14, 2018
@TheModMaker TheModMaker added this to the v2.5 milestone Sep 14, 2018
@TheModMaker TheModMaker self-assigned this Sep 17, 2018
joeyparrish pushed a commit that referenced this issue Oct 8, 2018
Closes #1585

Change-Id: Ic508e8e882c5a37c0545e19b09c58e642a00ec57
@joeyparrish
Copy link
Member

Fix cherry-picked to v2.4.5.

@shaka-project shaka-project locked and limited conversation to collaborators Nov 17, 2018
@joeyparrish joeyparrish added the component: captions/subtitles The issue involves captions or subtitles label May 19, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: TTML The issue involves TTML subtitles specifically status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants