Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate resolution entries with Angel One #2085

Closed
TheModMaker opened this issue Aug 7, 2019 · 1 comment
Closed

Duplicate resolution entries with Angel One #2085

TheModMaker opened this issue Aug 7, 2019 · 1 comment
Assignees
Labels
component: UI The issue involves the Shaka Player UI flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@TheModMaker
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v2.5.4 and nightly (v2.5.4-master-31-g438d5998)

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Demo app

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Chrome for Linux

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?
Angel One clip on home page.

What did you do?

  1. Load "Angel One" clip.
  2. Open resolution menu.

What did you expect to happen?
Should show only one entry for each resolution.

What actually happened?
Shows duplicate entries. For example, there are two for 576p.

@TheModMaker TheModMaker added type: bug Something isn't working correctly flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue component: UI The issue involves the Shaka Player UI labels Aug 7, 2019
@TheModMaker TheModMaker added this to the v2.6 milestone Aug 7, 2019
@TheModMaker
Copy link
Contributor Author

It looks like there are two English audio streams, which causes two variants for each resolution. We should be de-duping resolution selection to ensure we don't show duplicates if there are multiple "resolutions" of audio.

In this case, the reason there are two streams is because there is a 2-channel and a 6-channel audio option. ABR is only given the tracks that match the current channel count, but getVariantTracks returns all of them. We should also be filtering out tracks based on the "current" channel count.

@TheModMaker TheModMaker self-assigned this Aug 8, 2019
TheModMaker added a commit that referenced this issue Aug 22, 2019
Closes #2085

Change-Id: Idfdcd0cf89f43bd6a624afbb88e504d7653c9ae3
@shaka-project shaka-project locked and limited conversation to collaborators Oct 15, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants