Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucketize resolution names in the UI #2090

Closed
joeyparrish opened this issue Aug 8, 2019 · 8 comments · Fixed by #5816
Closed

Bucketize resolution names in the UI #2090

joeyparrish opened this issue Aug 8, 2019 · 8 comments · Fixed by #5816
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.
The resolutions menu in the UI shows exact heights in pixels, rather than using well-known names for resolutions like 1080p and 4k.

Describe the solution you'd like
The exact width & height should be used to choose a specific name for the resolution. The mapping could be configurable if needed.

Describe alternatives you've considered
Continue using height + 'p'? Let apps override the naming entirely?

Additional context
Some of this could be done in a custom overflow menu item, but that's not very easy at the moment.

@joeyparrish joeyparrish added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI labels Aug 8, 2019
@shaka-bot shaka-bot added this to the Backlog milestone Aug 8, 2019
@gregmsanderson

This comment has been minimized.

@TheModMaker
Copy link
Contributor

Seeing this, I tried the Angel One demo on https://shaka-player-demo.appspot.com and it does list common resolutions as 360p, 480p. However it duplicates them.

#2085.

@gregmsanderson
Copy link

Ah, the duplication has already been logged as a separate issue. Nice. Ignore this then

@joeyparrish
Copy link
Member Author

No worries, @gregmsanderson. To see this issue in action, try playing something that doesn't have a 4:3 aspect ratio, like Sintel (which is 64:27).

@ismena
Copy link
Contributor

ismena commented Aug 23, 2019

This was the duplicate of #2085 that has been fixed.

@ismena ismena closed this as completed Aug 23, 2019
@TheModMaker
Copy link
Contributor

I don't think that's what @joeyparrish meant for this issue. I think this issue was about taking videos that have similar resolutions and put them together. Instead of using the height followed by the letter 'p', we should provide pre-defined buckets to put the videos into (that is configurable). This will provide more "common" values for videos with slightly different sizes (e.g. we may not want to show an entry for 1081p).

@TheModMaker TheModMaker reopened this Aug 23, 2019
@ismena
Copy link
Contributor

ismena commented Aug 23, 2019

Ah, yes, you're probably right.

@jbglaw
Copy link

jbglaw commented Oct 5, 2019

I'd actually like to see the complete list of resolutions along with their exact width/height values. Maybe shortened for common stuff (ie. 720p, 1080p.)
Also, in "auto" mode, it would be nice to have an indication on the demo app which resolution is in use right now.

@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@theodab theodab added the priority: P3 Useful but not urgent label Sep 30, 2021
@avelad avelad modified the milestones: Backlog, v4.6 Oct 31, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 29, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants