Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't jump over the gap at the beginning before the video is played so that the video poster doesn't disappear. #3451

Closed
aradalvand opened this issue Jun 6, 2021 · 3 comments · Fixed by #3645
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@aradalvand
Copy link

aradalvand commented Jun 6, 2021

Have you read the FAQ and checked for duplicate open issues?
Yes.

What version of Shaka Player are you using?
3.1.0

Can you reproduce the issue with our latest release version?
Yes.

Can you reproduce the issue with the latest code from master?
Haven't tried.

Are you using the demo app or your own custom app?
Custom. But doesn't matter.

If custom app, can you reproduce the issue using our demo app?
You should be able to do so; using the below manifest URL.

What browser and OS are you using?
Browser: Chrome v91.0.4472.77
OS: Windows 10 build 19042.985

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?
Manifest: https://dash.akamaized.net/envivio/EnvivioDash3/manifest.mpd

What configuration are you using? What is the output of player.getConfiguration()?
Default.

What did you do?
Use the manifest URL above with a poster on the <video> tag. This particular manifest is a good example because there is a gap at the start of the video, and that's relevant.

What actually happened and what did you expect to happen?
If you do so, you'll see that the poster immediately disappears. The reason for this, as explained by @TheModMaker in this comment, is apprently because:

...there is a gap at the start. When we start playing, we see the gap at the start and seek over it. Because the time is no longer 0, the browser stops displaying the poster.

And that's in fact true. If you check the video's currentTime after the poster has disappeared, you'll see that it's greater than 0. However, I don't see why you would want to jump over the gap BEFORE the video is played, which is what causes the poster to disappear in the first place, why couldn't Shaka Player wait until the user plays the video, and then jump over the gap?
DASH.js, for example, behaves the way I just explained: It jumps over the gap at the start once the video is played, but not prior to that, as that would make the poster disappear. Couldn't Shaka Player adopt the same approach?

@ismena ismena added type: enhancement New feature or request priority: P3 Useful but not urgent and removed needs triage labels Jun 7, 2021
@ismena
Copy link
Contributor

ismena commented Jun 7, 2021

@joeyparrish I know you planned some a revamp og the gap jumping logic. Is this something you would consider as part of that?

@shaka-bot shaka-bot added this to the Backlog milestone Jun 7, 2021
@aahmadi458
Copy link

aahmadi458 commented Jun 11, 2021

@joeyparrish Any chance this will be solved in the next version?
I've been using Shaka Player for a long time now, but only recently I noticed this issue. Annoying.

@TheModMaker
Copy link
Contributor

It looks like this is caused by f7cc2f9, the fix for #2987. Since this was gated on autoplay, we should also check for this.video_.autoplay so we stay at 0 if we aren't playing.

@TheModMaker TheModMaker modified the milestones: Backlog, v3.2 Jun 18, 2021
@TheModMaker TheModMaker added type: bug Something isn't working correctly and removed type: enhancement New feature or request labels Jun 18, 2021
@joeyparrish joeyparrish modified the milestones: v3.2, v3.3 Jul 7, 2021
theodab pushed a commit that referenced this issue Oct 12, 2021
Before, the video would automatically gap jump at the start, even if the video
was not yet playing. This meant that videos with a gap at the start would jump
ahead and get rid of the video poster, even if autoplay was set to false.

Closes: #3451
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
Before, the video would automatically gap jump at the start, even if the video
was not yet playing. This meant that videos with a gap at the start would jump
ahead and get rid of the video poster, even if autoplay was set to false.

Closes: #3451
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
Before, the video would automatically gap jump at the start, even if the video
was not yet playing. This meant that videos with a gap at the start would jump
ahead and get rid of the video poster, even if autoplay was set to false.

Closes: #3451
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
Before, the video would automatically gap jump at the start, even if the video
was not yet playing. This meant that videos with a gap at the start would jump
ahead and get rid of the video poster, even if autoplay was set to false.

Closes: #3451
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 11, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
6 participants