Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't jump over the gap at the beginning before the video is played so that the video poster doesn't disappear. #3645

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Don't jump over the gap at the beginning before the video is played so that the video poster doesn't disappear. #3645

merged 1 commit into from
Oct 12, 2021

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 17, 2021

Close: #3451

Don't jump over the gap at the beginning before the video is played s…
a0f71f1 
…o that the video poster doesn't disappear.
@shaka-bot
Copy link
Collaborator

All tests passed!

@theodab theodab merged commit 9e15323 into shaka-project:master Oct 12, 2021
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
@joeyparrish
fix: Don't gap jump at start of video if autoplay is not set (#3645)
2fc746f 
Before, the video would automatically gap jump at the start, even if the video
was not yet playing. This meant that videos with a gap at the start would jump
ahead and get rid of the video poster, even if autoplay was set to false.

Closes: #3451
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
@joeyparrish
fix: Don't gap jump at start of video if autoplay is not set (#3645)
c43c37d 
Before, the video would automatically gap jump at the start, even if the video
was not yet playing. This meant that videos with a gap at the start would jump
ahead and get rid of the video poster, even if autoplay was set to false.

Closes: #3451
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
@joeyparrish
fix: Don't gap jump at start of video if autoplay is not set (#3645)
d99bc9f 
Before, the video would automatically gap jump at the start, even if the video
was not yet playing. This meant that videos with a gap at the start would jump
ahead and get rid of the video poster, even if autoplay was set to false.

Closes: #3451
@avelad avelad deleted the jump-gap-autoplay branch October 13, 2021 06:01
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
3 participants
@avelad @shaka-bot @theodab