issue/1985-fromCharCode-enhancement #1994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… array of char codes break the array in smaller chunks to avoid stach errors on low end devices add name to AUTHORS and CONTRIBUTORS
|
Thank you for this contribution. We spent some time discussing this internally, and we've decided to go with a slightly different fix, which will detect and adapt the chunk size to the device capabilities. |
|
Sounds good! How can I track that change - I would like to get updates when that will be added thanks! |
|
It went out to the master branch in 7bbca07, and I'll cherry-pick that to v2.5.x and release it in v2.5.3. In the mean time, you can use the master branch or our nightly build on appspot, which will have the fix around 4am PDT. |
AnteWall
pushed a commit
to AnteWall/shaka-player
that referenced
this pull request
Jul 17, 2019
Instead of using a hard-coded chunk size when creating large strings, this now uses a browser check to detect it. This allows us to use large chunk sizes on browsers that support it but still support low-end devices. Closes shaka-project#1985 Closes shaka-project#1994 Change-Id: Ibe45902b659516ae66bd7da33007fd15e7f64207
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For stringUtil.fromCharCode when creating a new string from the given array of char codes break the array in smaller chunks to avoid stack errors on low end devices