Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/1985-fromCharCode-enhancement #1994

Closed
wants to merge 1 commit into from
Closed

issue/1985-fromCharCode-enhancement #1994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Alugha GmbH <*@alugha.com>
Alvaro Velad Galvan <[email protected]>
Bonnier Broadcasting <*@bonnierbroadcasting.com>
Bryan Huh <[email protected]>
Dobrin Rusev <[email protected]>
Esteban Dosztal <[email protected]>
Fadomire <[email protected]>
Google Inc. <*@google.com>
Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Bryan Huh <[email protected]>
Chad Assareh <[email protected]>
Chris Fillmore <[email protected]>
Costel Madalin Grecu <[email protected]>
Dobrin Rusev <[email protected]>
Donato Borrello <[email protected]>
Duc Pham <[email protected]>
Esteban Dosztal <[email protected]>
Expand Down
2 changes: 1 addition & 1 deletion lib/util/string_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ shaka.util.StringUtils = class {
* @return {string}
*/
static fromCharCode(array) {
const max = 16000;
const max = 1000;
let ret = '';
for (let i = 0; i < array.length; i += max) {
const subArray = array.subarray(i, i + max);
Expand Down