Add pixelAspectRatio #2294
Merged
Add pixelAspectRatio #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theodab can you review it? |
theodab
reviewed
Dec 17, 2019
|
@theodab I have fixed the problem, it is ready to be reviewed again. |
|
@joeyparrish Can you review it again? |
joeyparrish
approved these changes
Jan 6, 2020
|
All tests passed! |
shaka-bot
pushed a commit
that referenced
this pull request
Jan 15, 2020
For backward compatibility, the new pixelAspectRatio field in Stream should be string|undefined rather than being nullable. This ensures that manifest parser plugins that do not output that field will still compile against the externs. PR #2294 Change-Id: I1aae03994a213c8ce52dc64e8a34bf179045f4fb
joeyparrish
pushed a commit
that referenced
this pull request
Jan 15, 2020
Backported to v2.5.x Change-Id: I413905c15ba5927cdd01e103c5f65070f06f4afa
joeyparrish
added a commit
that referenced
this pull request
Jan 15, 2020
For backward compatibility, the new pixelAspectRatio field in Stream should be string|undefined rather than being nullable. This ensures that manifest parser plugins that do not output that field will still compile against the externs. PR #2294 Backported to v2.5.x Change-Id: I1aae03994a213c8ce52dc64e8a34bf179045f4fb
|
This PR has been cherry-picked for v2.5.8. |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse pixelAspectRatio in DASH and expose it
Related to #2290