Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails if getInstalledDriverVersion encounters a permissions error #22

Closed
joeyparrish opened this issue Jun 20, 2023 · 0 comments · Fixed by #23 or #25
Closed

Fails if getInstalledDriverVersion encounters a permissions error #22

joeyparrish opened this issue Jun 20, 2023 · 0 comments · Fixed by #23 or #25
Labels
platform: Linux Issues affecting Linux priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@joeyparrish
Copy link
Member

If an installed driver is not executable by the user, a permissions error is thrown and the process stops. This can happen after interrupting the tool in between downloading and setting executable permissions.

It would be best if the tool assumed an incompatible version in case of a permissions error, and downloaded a new one.

As a workaround, the user can delete existing drivers.
@joeyparrish joeyparrish added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround platform: Linux Issues affecting Linux labels Jun 20, 2023
joeyparrish added a commit to joeyparrish/webdriver-installer that referenced this issue Jul 19, 2023
@joeyparrish
fix: Ignore errors executing non-executable drivers
aea74a7 
Sometimes WebDriver Installer can be interrupted after downloading,
but before setting the executable bits.  This leads to a failure later
when checking the WebDriver version.

We should ignore those errors and let WebDriver Installer replace the
driver instead.

Closes shaka-project#22
@joeyparrish joeyparrish mentioned this issue Jul 19, 2023
Merged
joeyparrish added a commit that referenced this issue Jul 19, 2023
@joeyparrish
fix: Ignore errors executing non-executable drivers (#23)
07c8644 
Sometimes WebDriver Installer can be interrupted after downloading, but
before setting the executable bits. This leads to a failure later when
checking the WebDriver version.

We should ignore those errors and let WebDriver Installer replace the
driver instead.

Closes #22
@github-actions github-actions bot mentioned this issue Jul 19, 2023
Merged
joeyparrish pushed a commit that referenced this issue Jul 19, 2023
@github-actions
chore(main): release 1.1.6 (#25)
b8a58b5 
🤖 I have created a release *beep* *boop*
---


##
[1.1.6](v1.1.5...v1.1.6)
(2023-07-19)


### Bug Fixes

* Ignore errors executing non-executable drivers
([#23](#23))
([07c8644](07c8644)),
closes
[#22](#22)
* Retry when WebDriver updates are not available yet
([#24](#24))
([e0312c8](e0312c8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Sep 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
platform: Linux Issues affecting Linux priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
1 participant
@joeyparrish