fix: Retry when WebDriver updates are not available yet #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some WebDriver updates for Chrome and Edge lag behind the corresponding browser releases. This will automatically retry with the previous 2 releases when a 404 is encountered. This fixes the failure on Chrome 115 today (ChromeDriver 115 is not out yet).
joeyparrish
changed the title
alekzz
approved these changes
Jul 19, 2023
|
|
||
| // Save the first error in case we run out this loop. We'll throw this | ||
| // one if none of the allowed versions can be found. | ||
| if (firstError == null) { |
There was a problem hiding this comment.
nit; Can use a nullish coalescing assignment:
firstError ??= error;
There was a problem hiding this comment.
This code doesn't get compiled, and nullish coalescing operators are only supported in node.js >= 14. That's not super new, but using that would also set a minimum requirement on this project and all dependent projects (like Shaka Player), so I would prefer not to use it.
There was a problem hiding this comment.
In particular, node.js minimum requirements are a pain for people who use a package manager for node.js installation. Although node.js 14 came out in 2020, there is not yet an Ubuntu LTS release with node.js >= 14 in a native package. (Ubuntu LTS from 2020 has node.js v10 from 2018, Ubuntu LTS from 2022 has node.js v12 from 2019, etc. It sucks.)
joeyparrish
pushed a commit
that referenced
this pull request
Jul 19, 2023
🤖 I have created a release *beep* *boop* --- ## [1.1.6](v1.1.5...v1.1.6) (2023-07-19) ### Bug Fixes * Ignore errors executing non-executable drivers ([#23](#23)) ([07c8644](07c8644)), closes [#22](#22) * Retry when WebDriver updates are not available yet ([#24](#24)) ([e0312c8](e0312c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
joeyparrish
added a commit
to joeyparrish/karma-local-wd-launcher
that referenced
this pull request
Jul 19, 2023
joeyparrish
added a commit
to shaka-project/karma-local-wd-launcher
that referenced
this pull request
Jul 19, 2023
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Jul 19, 2023
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this pull request
Jul 19, 2023
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this pull request
Jul 20, 2023
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this pull request
Jul 20, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some WebDriver updates for Chrome and Edge lag behind the corresponding browser releases. This will automatically retry with the previous 2 releases when a 404 is encountered.
This fixes the failure on Chrome 115 today (ChromeDriver 115 is not out yet).