Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

feat: bring over buildQuoteTx logic from platform-shared #71

Merged
merged 16 commits into from
Sep 29, 2021

Conversation

DaoDev44
Copy link
Contributor

@DaoDev44 DaoDev44 commented Sep 21, 2021

feat(ZrxSwapper): Add buildQuoteTx method to ZrxSwapper

  • Refactor private methods to helper functions for easier testing
  • add tests

closes #71

@DaoDev44 DaoDev44 changed the title wip - bring over buildQuoteTx logic feat: bring over buildQuoteTx logic from platform-shared Sep 24, 2021
@DaoDev44 DaoDev44 marked this pull request as ready for review September 24, 2021 21:35
@DaoDev44 DaoDev44 requested a review from a team as a code owner September 24, 2021 21:35
Copy link
Contributor

@toshiSat toshiSat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on error handling, but other than that lgtm

@0xdef1cafe 0xdef1cafe linked an issue Sep 27, 2021 that may be closed by this pull request
Copy link
Collaborator

@0xdef1cafe 0xdef1cafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

half way through just requesting these changes so they don't get lost

@DaoDev44 DaoDev44 force-pushed the lib-56-build-quote branch 3 times, most recently from 628c78b to c1e7732 Compare September 28, 2021 21:05
@DaoDev44 DaoDev44 merged commit 4ec3365 into main Sep 29, 2021
@DaoDev44 DaoDev44 deleted the lib-56-build-quote branch September 29, 2021 15:39
0xdef1cafe pushed a commit that referenced this pull request Oct 7, 2021
# @shapeshiftoss/swapper-v1.0.0 (2021-10-07)

### Features

* add approval needed to lib ([#95](#95)) ([0b1bae4](0b1bae4))
* add execute quote ([#87](#87)) ([463a06d](463a06d))
* add getdefaultpair to zrxswapper ([#91](#91)) ([d1cf1be](d1cf1be))
* get min max ([#93](#93)) ([26b788d](26b788d))
* **zrxSwapper:** add usd rate ([#85](#85)) ([1d5d36e](1d5d36e))
* bring over buildQuoteTx logic from platform-shared ([#71](#71)) ([4ec3365](4ec3365))
@0xdef1cafe
Copy link
Collaborator

🎉 This PR is included in version @shapeshiftoss/swapper-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swapper in Lib: implement buildQuoteTx
4 participants