This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
feat: add getdefaultpair to zrxswapper #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryankeepkey
reviewed
Oct 1, 2021
| it('gets default pair', () => { | ||
| const swapper = new ZrxSwapper(zrxSwapperDeps) | ||
| const pair = swapper.getDefaultPair() | ||
| expect(pair).toHaveLength(2) |
There was a problem hiding this comment.
Do you think it would be helpful to expect on a specific value for the pair, ie name = 'Ethereum' or something like that?
There was a problem hiding this comment.
Not really, it will just make it so when you change the values it will cause you to change it twice, but that does make me think.. we should probably at least check the chain type so that it is Ethereum there
toshiSat
changed the title
toshiSat
changed the title
elmutt
approved these changes
Oct 4, 2021
0xdef1cafe
approved these changes
Oct 4, 2021
0xdef1cafe
pushed a commit
that referenced
this pull request
Oct 7, 2021
# @shapeshiftoss/swapper-v1.0.0 (2021-10-07) ### Features * add approval needed to lib ([#95](#95)) ([0b1bae4](0b1bae4)) * add execute quote ([#87](#87)) ([463a06d](463a06d)) * add getdefaultpair to zrxswapper ([#91](#91)) ([d1cf1be](d1cf1be)) * get min max ([#93](#93)) ([26b788d](26b788d)) * **zrxSwapper:** add usd rate ([#85](#85)) ([1d5d36e](1d5d36e)) * bring over buildQuoteTx logic from platform-shared ([#71](#71)) ([4ec3365](4ec3365))
|
🎉 This PR is included in version @shapeshiftoss/swapper-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.