Icf cpheapm71 72 add guidelines #1118
Conversation
| NR = "not required", "not required" | ||
| REC = "recommended", "recommended" | ||
| REQ = "required", "required" | ||
| TR = "triggered", "triggered" |
There was a problem hiding this comment.
Added type checking for GuidelineProfile observation status, can be changed/removed as needed
| " public.vocab_term AS endpoint_category ON endpoint_type.parent_id = endpoint_category.id\n", | ||
| "WHERE\n", | ||
| " endpoint_target.type = 4 AND endpoint_target.namespace=2;\n", | ||
| "\"\"\"" |
There was a problem hiding this comment.
This notebook will probably be moved - mainly to demonstrate how guideline profiles were loaded (for review)
To load the model, I updated the endpoint ids in the given guideline_profiles spreadsheet to be the "endpoint target" (effect_subtype) id in the equivalent hawc vocab, and included the SQL logic for getting that here. Hopefully I didn't misunderstand the endpoints/goal here, but def let me know if I did!
| to="vocab.term", | ||
| ), | ||
| ), | ||
| ("endpoint_category", models.CharField(max_length=256)), |
There was a problem hiding this comment.
Guideline_profile_id is the primary key, and I kept the 3 vocab name fields that make up the endpoint. If they were mainly for my benefit to load in the vocab ids, I can remove them!
There was a problem hiding this comment.
This looks good generally, unfortunately I think we wanted to add it to the bioassay-v2 schema, not the bioassy-v1 schema.
To do that, I think this PR may need to be closed and reworked and then submitted as new PR that should be merged into the bioassay-v2 branch, not the main branch.
I think a lot of the code in the hawc.apps.animal will need to be modified and adapted to hawc.apps.animalv2. Hopefully that won't be too painful?
There was a problem hiding this comment.
Is this script needed? What's the purpose of it, and when would we call it?
71
72