Icf cpheapm73 79 add observations #1149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 11, 2024 13:16
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ZindahFarhaICF
commented
Dec 19, 2024
| serializer_class = serializers.GuidelineProfileSerializer | ||
| filename = "guideline_profiles" | ||
|
|
||
| def get_queryset(self, guideline=None) -> QuerySet: |
There was a problem hiding this comment.
Exports guideline profiles for an experiment
ZindahFarhaICF
commented
Dec 19, 2024
| /> | ||
| <label class="custom-control-label"> </label> | ||
| <span class="fa fa-spin fa-spinner float-right htmx-indicator"></span> | ||
| {% elif status == "tested_status" %} |
There was a problem hiding this comment.
Currently if a user isn't logged in, they can view (but not edit) observations, so they don't see the input checkbox
shapiromatron
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Just like #1118, I think this needs to be applied to animalv2 instead of animal.
To do that, I think this PR may need to be closed and reworked and then submitted as new PR that should be merged into the bioassay-v2 branch, not the main branch.
I think a lot of the code in the hawc.apps.animal will need to be modified and adapted to hawc.apps.animalv2. Hopefully that won't be too painful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates from tickets 73, 74, 79 for displaying toxrefdb observations
https://jira.epa.gov/browse/CPHEAPM-19
https://jira.epa.gov/browse/CPHEAPM-79