Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix: ios menu error #633

Merged
merged 2 commits into from
Dec 28, 2021
Merged

fix: ios menu error #633

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
736c489
fix: ios menu error
intergalacticspacehighway Dec 28, 2021
9d0ad3e
chore: naming things
intergalacticspacehighway Dec 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/expo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"react-native-crypto": "^2.1.0",
"react-native-gesture-handler": "^2.1.0",
"react-native-get-random-values": "^1.7.1",
"react-native-ios-context-menu": "1.3.0",
"react-native-ios-context-menu": "1.7.0",
"react-native-level-fs": "^3.0.0",
"react-native-localhost": "^1.0.0",
"react-native-mmkv": "1.3.2",
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
"clean": "yarn clean:turbo & yarn clean:node-modules",
"clean:turbo": "rm -rf ./node_modules/.cache/turbo",
"clean:node-modules": "find . -name 'node_modules' -type d -prune -exec rm -rf '{}' +",
"postinstall": "patch-package"
"postinstall": "patch-package",
"nuke": "yarn clean && rm -rf apps/storybook-react-native/android && rm -rf apps/storybook-react-native/ios && rm -rf apps/expo/android && rm -rf apps/expo/ios"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome addition!

My nitpick are not blockers but do you think clean:mobile might be a more aligned script name? Also if you have the time it could be helpful to add the new script to the script command section of the readme.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree about naming. I'll go for clean:native as it is removing the native iOS and Android folders.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! Updated and added in readme

},
"resolutions": {
"babel-preset-expo": "^8.5.1",
Expand Down
7 changes: 1 addition & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17478,12 +17478,7 @@ react-native-get-random-values@^1.7.1:
dependencies:
fast-base64-decode "^1.0.0"

[email protected]:
version "1.3.0"
resolved "https://registry.yarnpkg.com/react-native-ios-context-menu/-/react-native-ios-context-menu-1.3.0.tgz#b877cbe9594afccfeb2f1659ee4aae829b986fc5"
integrity sha512-7Af/5T9LGwdw+127UeiKrdCzlT247Puunts6pQ7HuKSW/33ZVJpxshDYjPiKEDYL94g5TDlIEsI93RC59x1Slw==

react-native-ios-context-menu@^1.3.0:
[email protected], react-native-ios-context-menu@^1.3.0:
version "1.7.0"
resolved "https://registry.yarnpkg.com/react-native-ios-context-menu/-/react-native-ios-context-menu-1.7.0.tgz#6fd1c8c62784e5bab31ad7b0f5e2884f46bb47c2"
integrity sha512-09ljn4MvBnwjHLdNfU1AVxw2PumGw9ug/h8pVFSU3Pc8aoyOKswx6gFoFo3mk/SL61SI5wr5/pZu92NvxGvfog==
Expand Down