Fix deneb doppelganger tests #4124
Conversation
|
Hoping this last run should pass CI 🤞 |
| @@ -26,7 +26,16 @@ jobs: | |||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | |||
| - name: Install ganache | |||
| run: npm install ganache@latest --global | |||
|
|
|||
| - name: Install geth | |||
There was a problem hiding this comment.
maybe good to mention in setup.md https://github.com/sigp/lighthouse/blob/unstable/book/src/setup.md?plain=1#L12
There was a problem hiding this comment.
Hey @atokama. We are using this for testing for 4844 specific stuff. This might not get merged for quite some time to the main branch. We have another PR #3807 where we should be ideally adding this and updating the docs for building post merge local testnets. Haven't been able to get around to that yet though 😅
|
Update: the failure scenario is not working for some reason despite logs indicating it should. Still checking it out |
This reverts commit 14eb178.
|
An update from inner talks. This is failing due to an expected/correct peer scoring event (peer is being banned). Work on #4135 should unblock this |
scripts/tests/vars.env
Outdated
| @@ -48,13 +56,7 @@ SECONDS_PER_SLOT=3 | |||
| SECONDS_PER_ETH1_BLOCK=1 | |||
|
|
|||
| # Proposer score boost percentage | |||
| PROPOSER_SCORE_BOOST=40 | |||
| PROPOSER_SCORE_BOOST=70 | |||
There was a problem hiding this comment.
Why this change? it's 40 in the spec: https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml#L88
Issue Addressed
N/A
Proposed Changes
Fixes doppelganger scripts.
Also makes the code compile by adding anunimplementedblock that should be resolved in #4092