Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add a flag to disable peer scoring #4135

Closed
wants to merge 5 commits into from

Conversation

pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Adds a flag for disabling peer scoring. This is useful for local testing and testing small networks for new features.

@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Mar 27, 2023
@divagant-martian divagant-martian added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Mar 27, 2023
@pawanjay176 pawanjay176 added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Mar 29, 2023
@pawanjay176
Copy link
Member Author

Works as expected in local testnets.

Copy link
Collaborator

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion but otherwise LGTM

beacon_node/src/cli.rs Show resolved Hide resolved
@divagant-martian
Copy link
Collaborator

divagant-martian commented Apr 3, 2023

conflicts arose. After that I think we can ship this. Since this is disabled by default I think this does not conflict with #4159

@pawanjay176
Copy link
Member Author

@divagant-martian any blocker for this?

@divagant-martian divagant-martian added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 10, 2023
@michaelsproul michaelsproul added the v4.1.0 Post-Capella minor release label Apr 12, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 12, 2023
## Issue Addressed

N/A

## Proposed Changes

Adds a flag for disabling peer scoring. This is useful for local testing and testing small networks for new features.
@bors bors bot changed the title Add a flag to disable peer scoring [Merged by Bors] - Add a flag to disable peer scoring Apr 12, 2023
@bors bors bot closed this Apr 12, 2023
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
## Issue Addressed

N/A

## Proposed Changes

Adds a flag for disabling peer scoring. This is useful for local testing and testing small networks for new features.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

N/A

## Proposed Changes

Adds a flag for disabling peer scoring. This is useful for local testing and testing small networks for new features.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v4.1.0 Post-Capella minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants