-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix disable backfill flag not working correctly #4615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
low-hanging-fruit
Easy to resolve, get it before someone else does!
v4.4.1
ETA August 2023
ready-for-review
The code is ready for review
labels
Aug 14, 2023
michaelsproul
added
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
and removed
ready-for-review
The code is ready for review
labels
Aug 14, 2023
michaelsproul
changed the title
Fix disable backfill flag not working correclty
Fix disable backfill flag not working correctly
Aug 14, 2023
jimmygchen
added
ready-for-review
The code is ready for review
and removed
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
labels
Aug 14, 2023
michaelsproul
approved these changes
Aug 14, 2023
michaelsproul
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Aug 14, 2023
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
## Issue Addressed The feature flag used to control this feature is `disable_backfill` instead of `disable-backfill`. kudos to @michaelsproul for discovering this bug!
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
Fix disable backfill flag not working correctly
[Merged by Bors] - Fix disable backfill flag not working correctly
Aug 14, 2023
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed The feature flag used to control this feature is `disable_backfill` instead of `disable-backfill`. kudos to @michaelsproul for discovering this bug!
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed The feature flag used to control this feature is `disable_backfill` instead of `disable-backfill`. kudos to @michaelsproul for discovering this bug!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
low-hanging-fruit
Easy to resolve, get it before someone else does!
ready-for-merge
This PR is ready to merge.
v4.4.1
ETA August 2023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
The feature flag used to control this feature is
disable_backfill
instead ofdisable-backfill
.kudos to @michaelsproul for discovering this bug!