Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix disable backfill flag not working correctly #4615

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix disable backfill flag not working correctly #4615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bd5e0e
Fix disable backfill feature flag not working correctly
jimmygchen Aug 14, 2023
f46633d
Use hyphen instead of underscore for the `network/disable-backfill` flag
jimmygchen Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions beacon_node/network/src/sync/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ impl<T: BeaconChainTypes> SyncManager<T> {

// If we would otherwise be synced, first check if we need to perform or
// complete a backfill sync.
#[cfg(not(feature = "disable_backfill"))]
#[cfg(not(feature = "disable-backfill"))]
if matches!(sync_state, SyncState::Synced) {
// Determine if we need to start/resume/restart a backfill sync.
match self.backfill_sync.start(&mut self.network) {
Expand All @@ -420,7 +420,7 @@ impl<T: BeaconChainTypes> SyncManager<T> {
}
Some((RangeSyncType::Finalized, start_slot, target_slot)) => {
// If there is a backfill sync in progress pause it.
#[cfg(not(feature = "disable_backfill"))]
#[cfg(not(feature = "disable-backfill"))]
self.backfill_sync.pause();

SyncState::SyncingFinalized {
Expand All @@ -430,7 +430,7 @@ impl<T: BeaconChainTypes> SyncManager<T> {
}
Some((RangeSyncType::Head, start_slot, target_slot)) => {
// If there is a backfill sync in progress pause it.
#[cfg(not(feature = "disable_backfill"))]
#[cfg(not(feature = "disable-backfill"))]
self.backfill_sync.pause();

SyncState::SyncingHead {
Expand Down