Skip to content
This repository has been archived by the owner on May 21, 2022. It is now read-only.

To All Major Contributors!!! Android Studio vs. Eclipse #188

Closed
a-r-db opened this issue May 1, 2015 · 14 comments
Closed

To All Major Contributors!!! Android Studio vs. Eclipse #188

a-r-db opened this issue May 1, 2015 · 14 comments
Labels
management Markdown and simpler issues. Very non critical.

Comments

@a-r-db
Copy link
Contributor

a-r-db commented May 1, 2015

@tgwizard has made the suggestion that we switch development of SLS from Eclipse to Android Studio
This will make it easier for @tgwizard and presumably, all of us too.

@Argoday @inverse @luisbandalap @metanota

We may have to drop the "sls_test" portion of the project, unless someone knows how to migrate it.
I already migrated and tested SLS in Android Studio.

I simple yes or no would be great.

I vote yes in hopes that it will make it easier for @tgwizard to contribute.

@a-r-db a-r-db added the management Markdown and simpler issues. Very non critical. label May 1, 2015
@inverse
Copy link
Contributor

inverse commented May 1, 2015

Works for me.is it worth getting all the current pull requests merged before though?

@a-r-db
Copy link
Contributor Author

a-r-db commented May 1, 2015

Yes, I am working on merging three major pull requests.
#149 #110
#101
@inverse Do you like #50 request? I am not sure what to do about it.

@luisbandalap
Copy link
Contributor

I agree on switching to Android Studio, it works well enough.
@HumbleBeeBumbleBee you could take a look at my fork, i already merged that commits without making so much changes.

@a-r-db
Copy link
Contributor Author

a-r-db commented May 1, 2015

Well, that's 5 against 2, so I guess we will be migrating. :)
@luisbandalap Are you 100% sure #149 and #110 and #50 are good and working?
I have read your comments and you seem certain.

@luisbandalap
Copy link
Contributor

Yes, indeed #110 is a must merge. I use my own fork saily and I don't have any problem with them.

Well maybe some conflicts when and music app (like poweramp) exposes both their API and Android Music Player API to SLS (some tracks are scrobbled earlier, some others doesn't), but i'm not sure it is because of #149.

@a-r-db
Copy link
Contributor Author

a-r-db commented May 1, 2015

@bryansills Thanks for the quick change, but we're going to merge some pull requests first.

@bryansills
Copy link
Contributor

#101 shouldn't be merged. That icon is outdated.

Also, mention me again when you are done with the merges. Android Studio is working for me (at least building the app), so I could probably send a pull request then. But I did kinda force the changes through git. Someone could probably make the changes more correctly than me. :0

@tgwizard
Copy link
Collaborator

tgwizard commented May 1, 2015

First, I must apologize to everyone that I haven't been here to maintain SLS properly. I'm truly sorry.

I really appreciate all the work you have put into SLS, with bug fixes, issues, pull requests and more. I know many people are using SLS (more than 500K downloads so far) and that you would like it to continue to become better. For me, I'd really like it if SLS could live on without me taking a too active role in its development.

I've given @HumbleBeeBumbleBee full access to the repository. I'm very much open to adding more of you as contributors. I'm happy to sign and upload new versions of SLS to Google Play, and, if wanted, answer questions and take part in discussions, perhaps even review code.

@HumbleBeeBumbleBee @inverse @metanota @bryansills @luisbandalap and others, great work so far, and a huge thank you for picking up the torch.

Humbly,
Adam

@metanota
Copy link
Contributor

metanota commented May 1, 2015

Feel free to migrate on whatever you want. I'm using Intellij Idea and I'll stay with it since it works perfectly with android applications and doesn't affects any of developers nor development processes.

Many thanks to @HumbleBeeBumbleBee who had literally awaken me (and probably not only me) from sleep with the recent activity :)

I would also like to see #149 to be extremely well tested before merging and hope that some of you has already tried to use it in the field.

@a-r-db
Copy link
Contributor Author

a-r-db commented May 1, 2015

Thanks everyone! Please download and test the latest pull #149.
https://github.com/tgwizard/sls/tree/testing-149
And post working applications in the dialogue for #149.

@a-r-db
Copy link
Contributor Author

a-r-db commented May 1, 2015

There is also https://github.com/tgwizard/sls/blob/master/IssueSummary.md
which I hope some contributors might use to find something to work on.
I'll be working on Spotify and VLC support for now.
Thanks!

@inverse
Copy link
Contributor

inverse commented May 2, 2015

@tgwizard First off, thanks for allowing other people to contribute with this awesome project you've created. I can imagine it must have been time consuming trying to keep on top of this considering how actively used it is. 👍

@HumbleBeeBumbleBee You've been going super crazy with trying to bring order to the this project with PR's, Issues, and collating data from the app store! well done 💃

I'd like to get involved more too although I feel these coming weeks might be a bit busy as I'll be starting a new job on Monday although perhaps in the evenings I'll have some time!

@inverse
Copy link
Contributor

inverse commented May 2, 2015

@HumbleBeeBumbleBee what problems are you having importing the sls_test project into Android Studio? When I did an import from an eclipse project it looks like everything went as expected. Aside some files it said were not copied and will need to be manually done.

@Argoday
Copy link
Contributor

Argoday commented May 5, 2015

+1 for Android Studio - they've made a lot of good progress over the eclipse version

Thx to @HumbleBeeBumbleBee for the activity!

@a-r-db a-r-db closed this as completed May 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
management Markdown and simpler issues. Very non critical.
Projects
None yet
Development

No branches or pull requests

7 participants