Scrobblers correctly handles track switching.

[metanota]

Hi.
This is the humble reincarnation of pull request #100. It fixed #44 and #99 for the most of the players.
Also I couldn't reproduce an issue with Google Play Music that @bmos have mentioned, so either developers have fixed it or I just forgot the correct scenario for it.
This fix doesn't resolve problems for all of the players which seem to be impossible, but I hope it helps in most of the cases.
I've checked it in PowerAmp, Google Play Music and Player Pro on SGS III. It'll be very helpful If some of you could also try this fix on your devices/players.

Also it may fixes #129. I've mentioned similar problem on vanilla sls and it never happened again since I'm using my fix to scrobble the music. It's definitely worth to double-check this.

[inverse]

I never really observed a problem before but than again I cant say I paid that close attention to the correctness of the scrobbling results.

I can confirm that this works on my Nexus 4 on Google Play music with repeated track playing, and normal usage.

Nice work :)

[a-r-db]

@metanota I have had the same problem. It occurs in most Receivers, built-in media players and media streamers.
I am currently working on a Spotify Receiver and it doesn't scrobble when the same song is played on repeat (offline or online) for Premium Users.
Maybe you could take a look. I am not sure how to fix it...
master...HumbleBeeBumbleBee:Spotify
This patch might even fix other bugs with Rdio and Spotify I think.
I hope @tgwizard merges this request soon so I can test if it works with Rdio and Spotify too.

[johnmaguire]

👍 This is an issue I've been tracking for a long time and would like to see fixed. Thanks for all your recent contributions @metanota

[a-r-db]

I think there's one probably with this merger with SamsungMusicReceiver.java that I modified recently.
"We can’t automatically merge this pull request."

[a-r-db]

OK the latest version of SLS with #149 https://github.com/tgwizard/sls/tree/testing-149 please test it!
I'll try testing as many application as I can.
It'd be great if people could list application tested and verified as working.

I couldn't find Winamp player though...

Also @metanota when everything is working and people report it working I was hoping you could fork testing-149 and make a pull request so I can give you credit. My git skills are limited sorry. Then I'll delete testing-149.

Not Affected

• Noise fm (x1)
• Rdio (x1)
• Spotify (x1)
• My Cloud Player (x1)
• SoundCloud (x1)

Working (and testing repeat single track)

• PowerAmp (x2) (after selecting PowerAmp>Settings>Misc>Scrobbling>Scrobble via SLS (checked))
• Google Play Music (x3)
• Player Pro (x2)

Repeat single track Not Working

• Vanilla (x2)
• SmartVanilla (x1)

Not Scrobbling Properly

• Stock Samsung Android Music Player (x1)
• VLC (x1)
• 8tracks (x1)

[a-r-db]

Just merged it...
I made sure they were identical @metanota

[a-r-db]

Looks like launching VLC causes SLS to crash for versions after #149.
Can anybody else confirm this?
I am going to add the code for Spotify and SoundCloud to make sure it's ju
I think I might hold off on adding all the changes in #149 until next version.
All my scrobbling went back to normal after switching back to before #149 or #191
Any chance you could rework your solution @metanota ?
@luisbandalap can you confirm any of this?
I don't believe #110 and this should conflict.

[metanota]

@HumbleBeeBumbleBee I'll look into VLC issue. Have you any exception logs about it?

All my scrobbling went back to normal after switching back to before #149 or #191

What other problems did you have with these changes?

[a-r-db]

Sorry, I have been using 8tracks to test scrobbling and it seems like it's an entirely unique problem with SLS and 8tracks not scrobbling to Last.fm.
It scrobbles to libre.fm so I am assuming the problem is with Last.fm
I am going to implement #149 on the next release probably 1.5.0.
I will do some more debugging.

[metanota]

I should definitely try 8tracks than :)

[a-r-db]

I found the problem @metanota 144-comment
Bad news: I have wasted your time.
Good news: I think we can apply your patches.