Skip to content
This repository has been archived by the owner on May 21, 2022. It is now read-only.

Scrobble on Wifi connected #110

Merged
merged 8 commits into from
May 1, 2015
Merged

Scrobble on Wifi connected #110

merged 8 commits into from
May 1, 2015

Conversation

inverse
Copy link
Contributor

@inverse inverse commented Dec 6, 2013

This changes adds a broadcast listener that attempts to scrobble whenever Wifi becomes connected. I added a new method to Utils so that it would silently attempt to do this so that no toast notification gets displayed if the cache is empty.

This is one of the first times I've tried to commit on github so any feedback/advice is appreciated :)

@inverse
Copy link
Contributor Author

inverse commented Dec 6, 2013

resolve #106

@inverse
Copy link
Contributor Author

inverse commented Feb 16, 2014

I've reverted Util.java as requested. Is this better?

@inverse
Copy link
Contributor Author

inverse commented Feb 25, 2014

Is there any further changes that you'd like me to make?

@inverse inverse closed this Jul 23, 2014
@inverse inverse deleted the wifi_scrobble branch July 23, 2014 20:15
@inverse inverse restored the wifi_scrobble branch July 23, 2014 20:18
@inverse inverse reopened this Jul 23, 2014
@tgwizard
Copy link
Collaborator

@inverse This looks good! Does anyone else have time to test this? Will try to find time.

@luisbandalap
Fix NPE on wifi connect
d2927c4 
For some weird reason database is not opened and when wifi connection is established SLS crashes because mDb is null, adding this little check solves it.
@luisbandalap
Copy link
Contributor

Please add this feature, i tested it and it works as expected.

@inverse
Copy link
Contributor Author

inverse commented Nov 30, 2014

Made the change you suggested. I hope you didn't mind the small tidy up I made.

Any chance we could get this PR merged?

@a-r-db
Copy link
Contributor

a-r-db commented May 1, 2015

@inverse and @luisbandalap I will test this soon.

@a-r-db a-r-db mentioned this pull request May 1, 2015
Closed
@a-r-db
Copy link
Contributor

a-r-db commented May 1, 2015

Looks good :) merging...

a-r-db pushed a commit that referenced this pull request May 1, 2015
Merge pull request #110 from inverse/wifi_scrobble
68664bb 
Scrobble on Wifi connected
@a-r-db a-r-db merged commit 68664bb into simple-last-fm-scrobbler:master May 1, 2015
@inverse inverse deleted the wifi_scrobble branch May 2, 2015 16:52
@a-r-db a-r-db mentioned this pull request May 4, 2015
Closed
a-r-db pushed a commit that referenced this pull request May 6, 2015
Revert #110
1cfb3c5 
8tracks not scrobbling and other users are reporting our changes as
making things worse.
#80 @arkdae
@a-r-db a-r-db mentioned this pull request May 31, 2015
Merged
@a-r-db a-r-db mentioned this pull request Aug 9, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inverse @tgwizard @luisbandalap @a-r-db