Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiDex support: now secondary dex'es are located directly in apk file,... #482

Closed
wants to merge 1 commit into from

Conversation

lsuski
Copy link

@lsuski lsuski commented Oct 20, 2014

... not in assets (compatible with android.support.MultiDex)

To make this work one should add these lines to main-dex-list file:
android/support/multidex/MultiDex.class
android/support/multidex/MultiDex$V4.class
android/support/multidex/MultiDex$V14.class
android/support/multidex/MultiDex$V19.class
android/support/multidex/MultiDexApplication.class
android/support/multidex/MultiDexExtractor.class
android/support/multidex/MultiDexExtractor$1.class
android/support/multidex/ZipUtil.class
android/support/multidex/ZipUtil$CentralDirectory.class

…le, not in assets (compatible with android.support.MultiDex)
@mosabua
Copy link
Member

mosabua commented Oct 21, 2014

Those multidex class files have to come from somewhere... how do they get into the apk?

@lsuski
Copy link
Author

lsuski commented Oct 21, 2014

Those classes come from android.support.multidex library which can be found in android sdk (latest support repository). Check this https://developer.android.com/reference/android/support/multidex/MultiDex.html

@fledain
Copy link

fledain commented Oct 29, 2014

I do confirm: my application can't execute today on my device since the additional dex files are misplaced in the final APK (/assets/ instead of /). I have reviewed Łukasz's patch, and I fully agree.
Please provide an rc4 ASAP please.

@bastoi
Copy link

bastoi commented Oct 31, 2014

I do confirm too. I test this patch and it's necessary to work properly with multidex.

@siepkes
Copy link

siepkes commented Nov 10, 2014

I too can confirm this patch is needed when using Android Support Multidex as described here: https://developer.android.com/tools/building/multidex.html . Is there anything I can do do speed up the process of getting this in master (and perhaps rc.4)?

@Shusshu
Copy link
Member

Shusshu commented Nov 12, 2014

I can make sure it goes into master but I'm currently not able to test it.
Could someone make a sample project so I can try it?

For the release rc.4 we would need to wait for Manfred (a few days)

@mosabua mosabua closed this Nov 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants