Multidex an Proguard fixes

[lsuski]

I made changes for multidexing on fresh fork and also add fix for Proguard command line parameters. Related to
#482 (can be rejected)
and
#507

[william-ferguson-au]

Is there a test for multi dex?
On 18 Nov 2014 00:29, "Łukasz Suski" [email protected] wrote:

I made changes for multidexing on fresh fork and also add fix for Proguard
command line parameters. Related to
#482 #482 (can
be rejected)
and

#507 #507

You can merge this Pull Request by running

git pull https://github.com/lsuski/android-maven-plugin master

Or view, comment on, or merge it at:

#509
Commit Summary

• MultiDex support: now secondary dex'es are located directly in apk
  file, not in assets (compatible with android.support.MultiDex)
• generated Proguard parameters are passed to Proguard through
  temporary config file instead of full command line options

File Changes

• M
  src/main/java/com/jayway/maven/plugins/android/phase04processclasses/ProguardMojo.java
  https://github.com/simpligility/android-maven-plugin/pull/509/files#diff-0
  (104)
• M
  src/main/java/com/jayway/maven/plugins/android/phase08preparepackage/DexMojo.java
  https://github.com/simpligility/android-maven-plugin/pull/509/files#diff-1
  (41)
• M
  src/main/java/com/jayway/maven/plugins/android/phase09package/ApkMojo.java
  https://github.com/simpligility/android-maven-plugin/pull/509/files#diff-2
  (77)

Patch Links:

• https://github.com/simpligility/android-maven-plugin/pull/509.patch
• https://github.com/simpligility/android-maven-plugin/pull/509.diff

—
Reply to this email directly or view it on GitHub
#509.

[mosabua]

Awesome ... I will check it out tonight or later this week.

[lsuski]

@william-ferguson-au
I've tested it but didn't write any automatic test.

[william-ferguson-au]

Can you add a test?
As simple as a project that uses multi-dex and executes some activity or
uses some resources from the 2nd dex.

On Tue, Nov 18, 2014 at 1:27 AM, Łukasz Suski [email protected]
wrote:

@william-ferguson-au https://github.com/william-ferguson-au
I've tested it but didn't write any automatic test.

—
Reply to this email directly or view it on GitHub
#509 (comment)
.

[lsuski]

I'll try but I am not familiar with those kind of tests, I have simple test project but don't know how exactly test it. Is there any similar test I could base on?

[Shusshu]

You can just share a sample project.

As simple as a project that uses multi-dex and executes some activity or uses some resources from the 2nd dex.

[bastoi]

I think that it's difficult to know which classes are put to the second dex because dx tool manages this process.

You can try to create a project adding multiple jars to overflow 64k method limit.

Then maven with multi-dex flag to true generates two dex files (you can open the apk to see it at the root folder).

Then if your sample project has multidex enabled when you run the application you can see to the log how Multidex class load the secondary dex file.

[Shusshu]

You could try to put 3 or 4 huge libraries: (play services, guava, aws (amazon)) and then call some stuff from each of them...

[mosabua]

An example project and a IT test would be nice. But as it stands this looks good already as well.

[lsuski]

Sorry for delay,
this is sample project https://github.com/lsuski/maven-multidex-sample . Check README. I'm not familiar with integration tests so if someone want to write test feel free to include this project in it.