Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Node.js v11 #196

Closed
fstoerkle opened this issue Apr 5, 2019 · 2 comments
Closed

Support for Node.js v11 #196

fstoerkle opened this issue Apr 5, 2019 · 2 comments

Comments

@fstoerkle
Copy link

In Node.js v11, the callback parameter to pipeline was made obligatory: nodejs/node#21054

Subsequently, running file-type with Node.js v11 fails with this error:

TypeError [ERR_INVALID_CALLBACK]: Callback must be a function

I ran the test suite on Travis CI, which confirms this: https://travis-ci.com/fstoerkle/file-type/jobs/190598883
@jfinkhaeuser
Copy link
Contributor

bump

@jfinkhaeuser jfinkhaeuser mentioned this issue Apr 9, 2019
Merged
sindresorhus pushed a commit that referenced this issue Apr 9, 2019
@jfinkhaeuser @sindresorhus
Fix Node.js 11 compatibility (#198)
ee0ee82 
Fixes #196
@siman siman mentioned this issue Apr 9, 2019
Closed
@siman
Copy link

siman commented Apr 9, 2019

Hey @sindresorhus, can you make a minor release w/ this fix, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fstoerkle @siman @jfinkhaeuser