Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node.js 11 compatibility #198

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Fix Node.js 11 compatibility #198

merged 2 commits into from
Apr 9, 2019

Conversation

jfinkhaeuser
Copy link
Contributor

Fixes #196

@sindresorhus sindresorhus changed the title Fix #196 by providing the mandatory callback. Fix Node.js 11 compatibility Apr 9, 2019
@sindresorhus sindresorhus merged commit ee0ee82 into sindresorhus:master Apr 9, 2019
@fstoerkle
Copy link

fstoerkle commented Apr 9, 2019

I guess now it would make sense to also include Node.js 11 in the .travis.yml?

fstoerkle added a commit to fstoerkle/file-type that referenced this pull request Apr 9, 2019
As of sindresorhus#198, file-type should also work on Node.js 11.
Running the tests on Node.js 11 would verify that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants