Rollback Git operations when publish fails and on termination

[itaisteinherz]

This is my first attempt at fixing #197. The code's not really working for some reason, and I'm pushing this to get an initial review since I've been trying to get this to work for nearly two weeks.

Fixes #197

[sindresorhus]

When publish fails it doesn't rollback:

? Will bump from 1.2.0 to 1.2.1. Continue? Yes
  ✔ Prerequisite check
  ✔ Git
  ✔ Bumping version using npm
  ✔ Prerequisite check
  ✔ Git
  ✔ Bumping version using npm
  ✔ Publishing package using npm
  ↓ Pushing tags [skipped]
    → Couldn't publish package to npm; not pushing.
  ✔ Creating release draft on GitHub

 sindre-playground 1.2.1 published 🎉

It's weird that ✔ Publishing package using npm has a checkmark, even though it failed. And if publish fails, it should cancel any following tasks, like creating release draft.

[itaisteinherz]

It's weird that ✔ Publishing package using npm has a checkmark, even though it failed.

I noticed this as well, but haven't figured out why it happens yet. I'll dive into the issue later today.

[itaisteinherz]

@sindresorhus aae3a7e should fix some of the issues you were talking about.

[sindresorhus]

Let me know when #334 (comment) is fixed.

[itaisteinherz]

@sindresorhus It is fixed. The current issue is that when terminating np while the package is being published, rollback isn't called and the project doesn't get rolled back.

[itaisteinherz]

@sindresorhus The origin of the issue was that I used async-exit-hook incorrectly (see dd540e3) 😅

[itaisteinherz]

@sindresorhus Do you think we should add a note about this to the readme? (probably in the Why section)

[sindresorhus]

Add a note about what?

[itaisteinherz]

Add a note about what?

The fact the np rolls back the project to its previous state in case the publish fails or if it gets terminated.

[sindresorhus]

It doesn't seem to work when the publish command fails. Just for testing I changed the actual command from npm publish to npm publish2:

~/dev/oss/sindre-playground master
❯ np

Publish a new version of sindre-playground (current: 1.2.3)

? No commits found since previous release, continue? Yes
? Select semver increment or specify new version patch 	1.2.4
? Will bump from 1.2.3 to 1.2.4. Continue? Yes
  ✔ Prerequisite check
  ✔ Git
  ↓ Cleanup [skipped]
  ✔ Prerequisite check
  ✔ Git
  ↓ Cleanup [skipped]
  ✔ Installing dependencies using npm
  ✔ Running tests using npm
  ✔ Bumping version using npm
  ✖ Publishing package using npm
    → The project was rolled back to its previous state.
    Pushing tags
    Creating release draft on GitHub

✖ Error publishing package:
Command failed: npm publish2


Usage: npm <command>

where <command> is one of:
    access, adduser, audit, bin, bugs, c, cache, ci, cit,
    clean-install, clean-install-test, completion, config,
    create, ddp, dedupe, deprecate, dist-tag, docs, doctor,
    edit, explore, get, help, help-search, hook, i, init,
    install, install-ci-test, install-test, it, link, list, ln,
    login, logout, ls, org, outdated, owner, pack, ping, prefix,
    profile, prune, publish, rb, rebuild, repo, restart, root,
    run, run-script, s, se, search, set, shrinkwrap, star,
    stars, start, stop, t, team, test, token, tst, un,
    uninstall, unpublish, unstar, up, update, v, version, view,
    whoami

npm <command> -h  quick help on <command>
npm -l            display full usage info
npm help <term>   search for help on <term>
npm help npm      involved overview

Specify configs in the ini-formatted file:
    /Users/sindresorhus/.npmrc
or on the command line via: npm <command> --key value
Config info can be viewed via: npm help config

[email protected] /Users/sindresorhus/n/lib/node_modules/npm

Did you mean one of these?
    publish
    unpublish


The project was rolled back to its previous state.

It says it rolled back the state, but I still have the 1.2.4 commit and tag.

[sindresorhus]

The fact the np rolls back the project to its previous state in case the publish fails or if it gets terminated.

Yes, definitely. Should also be mentioned in the highlights as it's a good feature.

[itaisteinherz]

It says it rolled back the state, but I still have the 1.2.4 commit and tag.

Fixed in 0ed1047.
(The issue was that the commit message when using npm is x.x.x while the message when using yarn is vx.x.x. The rollback function didn't account for the inconsistency, which made the rollback fail.)

[itaisteinherz]

@sindresorhus I think that this is ready to be merged.

@NeekSandhu @SamVerschueren It would be great if you could test this out and let me know if this works for you as expected.

[sindresorhus]

It's working well for me :)

[sindresorhus]

Found another issue. It shows the rollback message when a running the tests and a test fails. However, it's not technically rolling back anything then as nothing has been committed yet.

? Select semver increment or specify new version major 	2.0.0

  ✔ Prerequisite check
  ✔ Git
  ✔ Cleanup
  ✔ Installing dependencies using npm
  ✖ Running tests using npm
    →   1 error
    Bumping version using npm
    Publishing package using npm
    Pushing tags
    Creating release draft on GitHub

✖ Command failed: npm test
npm ERR! Test failed.  See above for more details.


> [email protected] test /Users/sindresorhus/dev/oss/stringify-attributes
> xo && ava && tsd


  index.js:5:8
  ✖  5:8  Parsing error: Identifier attributes has already been declared

  1 error


Publish failed. Rolling back to the previous state…

[itaisteinherz]

@sindresorhus I opened an issue to track this: #396.