Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback Git operations when publish fails and on termination #334

Merged
merged 15 commits into from
Mar 31, 2019
Merged

Rollback Git operations when publish fails and on termination #334

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1d51e51
Rollback when publish fails and on SIGINT
itaisteinherz Jan 20, 2019
b6b0020
Update index.js
sindresorhus Jan 22, 2019
3a1bd27
Review improvements
itaisteinherz Jan 22, 2019
cc57b69
Move Git commands to `git-util.js`
itaisteinherz Jan 27, 2019
6611ee0
Avoid returning unused values
itaisteinherz Jan 27, 2019
09ee92b
Return Observable on publish
itaisteinherz Feb 14, 2019
855e366
Fix publish task
itaisteinherz Feb 15, 2019
f7a83bd
Catch process SIGINT event using `async-exit-hook`
itaisteinherz Feb 20, 2019
1e1f12a
Merge branch 'master' into rollback-on-publish-fail
itaisteinherz Feb 21, 2019
aae3a7e
Fix rollback after publishing failed
itaisteinherz Feb 22, 2019
061e5c9
Review improvements
itaisteinherz Feb 23, 2019
07adf91
Merge branch 'master' into rollback-on-publish-fail
itaisteinherz Feb 23, 2019
dd540e3
Fix exit event handling
itaisteinherz Feb 28, 2019
0ed1047
Fix rollback when using npm
itaisteinherz Mar 15, 2019
e8e90fe
Mention feature in the readme
itaisteinherz Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions source/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,15 @@ module.exports = async (input = 'patch', options) => {
const hasLockFile = fs.existsSync(path.resolve(rootDir, 'package-lock.json')) || fs.existsSync(path.resolve(rootDir, 'npm-shrinkwrap.json'));
const isOnGitHub = options.repoUrl && hostedGitInfo.fromUrl(options.repoUrl).type === 'github';

let published = false;
let isPublished = false;

const rollback = onetime(async () => {
itaisteinherz marked this conversation as resolved.
Show resolved Hide resolved
console.log('\nPublish failed. Rolling back to the previous state…');

const lastCommit = await execa.stdout('git', ['log', '-1', '--pretty=%B']);
const lastCommit = await execa.stdout('git', ['log', 'HEAD^..HEAD', '--pretty=%B']);
itaisteinherz marked this conversation as resolved.
Show resolved Hide resolved
try {
if (lastCommit === util.readPkg().version && lastCommit !== pkg.version) {
await execa('git', ['tag', '-d', options.version]);
await execa('git', ['tag', '--delete', options.version]);
await execa('git', ['reset', '--hard', 'HEAD~1']);
}

Expand All @@ -77,7 +77,7 @@ module.exports = async (input = 'patch', options) => {
});

process.on('SIGINT', async () => {
itaisteinherz marked this conversation as resolved.
Show resolved Hide resolved
if (!published && runPublish) {
if (!isPublished && runPublish) {
await rollback();
}

Expand Down Expand Up @@ -177,7 +177,7 @@ module.exports = async (input = 'patch', options) => {
task: async (context, task) => {
try {
await publishTaskHelper(pkgManager, task, options, input);
itaisteinherz marked this conversation as resolved.
Show resolved Hide resolved
published = true;
isPublished = true;
} catch (_) {
rollback();
itaisteinherz marked this conversation as resolved.
Show resolved Hide resolved
}
Expand All @@ -193,7 +193,7 @@ module.exports = async (input = 'patch', options) => {
return 'Upstream branch not found; not pushing.';
}

if (!published && runPublish) {
if (!isPublished && runPublish) {
return 'Couldn\'t publish package to npm; not pushing.';
}
},
Expand Down