Commonjs-ified sinon.spy

[fearphage]

Updated sinon.spy to make use of cjs'd modules and to export itself using commonjs styling.

Notable changes

• moved sinon.format to core in the process. Core seems like a placeholder that will one day go away
• sinon.spyCall is exposed solely for testing (both uses of it internally are commonjs-fied)
• Due to a few tests, I could not remove the sinon/core include from spy (related to sinon.format)

[fearphage]

Exposed solely for testing purposes? It seems like an internal tool only though.

[mantoni]

I think this was used internally. I think it can be removed since it would be released with a major. @cjohansen do you recall?

[cjohansen]

Not a part of the external API at least.

[fearphage]

It's exposed publicly, because that's how it is tested (see call-test.js).

[fearphage]

Just rerunning the tests. 😉

[mroderick]

@fearphage this is a very nice pull request. I love how easy it is to follow along, when there are separate commits for each step. 👍

[fearphage]

@mroderick Thank you. I appreciate it.

[mantoni]

Very nice, indeed. Are you intending to clear up the "format coupling" within this pull request or is this going to happen separately?

[fearphage]

I think the tests need to be refactored in a big way to fix the call+format tests. I think this code is good to merge. I wasn't planning on decoupling them in this PR. I'm always open to suggestions though.

[fearphage]

So what's the word, folks?

[fatso83]

Sorry for keeping you waiting. Very nice work, indeed.

[fearphage]

FYI, you can now import this separately from everything else.

$ node
> var foo = require('sinon/lib/sinon/spy')();
> foo.callCount
1

I haven't used it, but I know it can be included at least. I was wondering if anyone considered pulling out the separate pieces into different repos or at least different npm targets. Imagine npm install sinon-spy. Just something to think about.

Thanks everyone.

[cjohansen]

Awesome! That's definitely something I've thought about more than once.