CommonJSify sinon.mock
#933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `spy.js`, the tests have a hard dependency on `sinon.format` which can't be removed until the tests themselves are CommonJSify'd
Extract, `sinon.expectation`, an inner module into its own CommonJS module (`mock-expectation`). This is still exported on the `sinon` object to satisfy tests.
|
Very nice work, thank you! Especially that you managed to refactor quite a handful, without touching any tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #920 and #932, I've extracted
sinon.mock; and just for fun,sinon.assertandcreateSpyCallinto standalone CommonJS modules! 🚀Notable Changes
sinon.expectationinto it's own module,mock-expectationto satisfy the tests and keep themockmodule clean. Once the tests are migrated to CommonJS we can remove this from the public API.