Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add image of car as icon to device_tracker #2

Closed
Prior99 opened this issue Sep 12, 2024 · 0 comments · Fixed by #90
Closed

[Feature] Add image of car as icon to device_tracker #2

Prior99 opened this issue Sep 12, 2024 · 0 comments · Fixed by #90
Assignees
Labels
enhancement New feature or request

Comments

@Prior99
Copy link
Contributor

Prior99 commented Sep 12, 2024

Original issue in old repository by @sonar98.

In the Skodaconnect version the device_tracker icon shows the image that is available from the API.

image

I think this part of the code in the init.py is getting this image:

if "position" in self.attribute:
    # Try to use small thumbnail first hand, else fallback to fullsize
    if self.vehicle.is_model_image_small_supported:
        attributes["entity_picture"] = self.vehicle.model_image_small
    elif self.vehicle.is_model_image_large_supported:
        attributes["entity_picture"] = self.vehicle.model_image_large

return attributes
@dvx76 dvx76 added the enhancement New feature or request label Oct 8, 2024
@dvx76 dvx76 self-assigned this Oct 12, 2024
dvx76 added a commit to dvx76/homeassistant-myskoda that referenced this issue Oct 12, 2024
dvx76 added a commit to dvx76/homeassistant-myskoda that referenced this issue Oct 15, 2024
@dvx76 dvx76 closed this as completed in #90 Oct 15, 2024
dvx76 added a commit that referenced this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants