Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image render sensor and in device tracker #90

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dvx76
Copy link
Member

@dvx76 dvx76 commented Oct 12, 2024

Fixes #2

@dvx76 dvx76 requested review from WebSpider and Prior99 October 12, 2024 18:57
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2 is about adding the render to the device tracker, i dont see the setting of a picture in the device_tracker here?

@sonar98
Copy link
Contributor

sonar98 commented Oct 12, 2024

the part in device_tracker.py starting at line 84 is adding the image:

attributes["entity_picture"]

@dvx76
Copy link
Member Author

dvx76 commented Oct 12, 2024

linter will pass when new myskoda package is released and picked up here.

Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait for the linter to pass before merging it

@WebSpider
Copy link
Contributor

the part in device_tracker.py starting at line 84 is adding the image:

attributes["entity_picture"]

Learn something new every day about HA. I thought it was the picture property of the device_tracker.

@WebSpider
Copy link
Contributor

@dvx76 if you rebase / merge main the linter should pass.

@dvx76 dvx76 force-pushed the image-render-sensor branch from 2048510 to 4a5de6e Compare October 15, 2024 17:57
@dvx76
Copy link
Member Author

dvx76 commented Oct 15, 2024

rebased

@dvx76 dvx76 merged commit 57b1e0d into skodaconnect:main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add image of car as icon to device_tracker
3 participants