Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range entity no longer working #302

Closed
TheMrBooyah opened this issue Nov 16, 2024 · 9 comments · Fixed by #305
Closed

Range entity no longer working #302

TheMrBooyah opened this issue Nov 16, 2024 · 9 comments · Fixed by #305
Assignees
@dvx76
Labels
bug Something isn't working

Comments

@TheMrBooyah
Copy link

TheMrBooyah commented Nov 16, 2024 •
edited
Loading

Describe the bug
Since the update to 1.9.0 I noticed I no longer have a valid range value.
I'm using the integration with my Skoda Enyaq IV

Is this working in MySkoda app?*
Yes I can see the range in the MySkoda App

Latest working release
Pre 1.9.0

Debug logs
If applicable, add debug logs. Debug logs help us locate and fix a problem quicker

Installation:
Core: 2024.11.2
Supervisor: 2024.11.2
Operating System: 13.2
Frontend: 20241106.2

image
@TheMrBooyah TheMrBooyah added the bug Something isn't working label Nov 16, 2024
@WebSpider
Copy link
Contributor

We'll need more logging since it is working on my Enyaq with 1.9.1

@WebSpider WebSpider added the need-more-info More information needed label Nov 16, 2024
@TheMrBooyah
Copy link
Author

home-assistant_myskoda_2024-11-16T19-54-10.454Z.log

Did enable debug logging but didn't see any errors to indicate anything going wrong. Removed VIN number and other unrelated log lines from other integrations.

@WebSpider
Copy link
Contributor

Can you enable tracing as well, in the integration options (right next to the S-PIN)

@TheMrBooyah
Copy link
Author

home-assistant_myskoda_2024-11-16T22-50-58.236Z.log
Should have all private information redacted.
I did notice that I do get this information back in one of the API calls:
"remainingCruisingRangeInMeters":224000

@WebSpider
Copy link
Contributor

Yes, it is, however since we support electric, hybrid and ice vehicles, we get the data from a different endpoint, but that endpoint i do not see queried in this log. Is the log complete? It would seem to miss a few endpoints

@TheMrBooyah
Copy link
Author

TheMrBooyah commented Nov 16, 2024 •
edited
Loading

This is everything I get in the logging. I stopped when I got a lot of:
2024-11-17 00:12:52.098 DEBUG (MainThread) [myskoda.mqtt] Sending PINGREQ
2024-11-17 00:12:52.111 DEBUG (MainThread) [myskoda.mqtt] Received PINGRESP

Mind telling me what endpoint you are expecting to see?

I suspect you're expecting /v2/vehicle-status/{VIN}/driving-range. If so, this is not inside the logging so it seems to not be called by the integration

Maybe this also helps but I do not have all subscriptions active.
The ones I currently have active:

  • Infotainment Online
  • Powerpass Map

@dvx76
Copy link
Member

dvx76 commented Nov 17, 2024

Possibly related to #268 - range was changed to populate from driving_range instead of battery

@dvx76
Copy link
Member

dvx76 commented Nov 17, 2024

The driving_range endpoint is only queried if we see the STATE capability. From some of user-submitted fixtures I see that can be unavailable based on inactive subscriptions

      - id: STATE
        statuses:
        - LICENSE_MISSING
        - LICENSE_EXPIRED

So that is likely what is happening here.

I think maybe for the Range sensor we have it fall back to the range from the battery data if the driving_range isn't available ?

@WebSpider
Copy link
Contributor

WebSpider commented Nov 17, 2024 •
edited
Loading

Yeah, if the car has the right capabilities and the license is missing, we can fall back indeed.

@dvx76 dvx76 self-assigned this Nov 17, 2024
@dvx76 dvx76 removed the need-more-info More information needed label Nov 17, 2024
dvx76 added a commit to dvx76/homeassistant-myskoda that referenced this issue Nov 17, 2024
@dvx76
Let Range fall back to battery if driving_range is missing
48a558e 
Due to missing subscriptions for the STATE capability the driving_range
can be missing while the battery data is available.

Fixes skodaconnect#302
@dvx76 dvx76 mentioned this issue Nov 17, 2024
Merged
dvx76 added a commit to dvx76/homeassistant-myskoda that referenced this issue Nov 18, 2024
@dvx76
Let Range fall back to battery if driving_range is missing
aa79fd6 
Due to missing subscriptions for the STATE capability the driving_range
can be missing while the battery data is available.

Fixes skodaconnect#302
dvx76 added a commit that referenced this issue Nov 19, 2024
@dvx76
Let Range fall back to battery if driving_range is missing (#305)
cd6568f 
Due to missing subscriptions for the STATE capability the driving_range
can be missing while the battery data is available.

Fixes #302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvx76 dvx76

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Let Range fall back to battery if driving_range is missing dvx76/homeassistant-myskoda
3 participants
@WebSpider @dvx76 @TheMrBooyah