Change range to work with all car types, make icon car-type dependant #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed range to use value from driving_range.total_range_in_km instead of a value from charging (so it can be used by all engine types)
dvx76
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Great. No idea why we didn't use the range from the driving_range right away 🤷♂️
Minor comment + linter wants an extra newline (tip: install https://docs.astral.sh/ruff/ in your editor and it will auto-format things for you right away)
WebSpider
approved these changes
Nov 13, 2024
WebSpider
approved these changes
Nov 13, 2024
WebSpider
changed the title
WebSpider
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed range to use value from driving_range.total_range_in_km instead of a value from charging (so it can be used by all engine types)