Rm old solidity #12569
Merged
Rm old solidity #12569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
|
RyanRHall
reviewed
Mar 25, 2024
| ), | ||
| ) | ||
| }) | ||
| // it('cannot call functions on the LINK token through callbacks', async () => { |
There was a problem hiding this comment.
/nit add a TODO with ticket to add this back in or remove?
i.e.
// TODO: BCI-9999
There was a problem hiding this comment.
Where should the ticket live? There are no actual owners
There was a problem hiding this comment.
You could put something in foundations if you wanted
patrickhuie19
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old 0.4 and 0.5 Solidity contracts. Some of them were used in 0.8 Hardhat tests, so some migrations have been done from 0.4 to 0.8 for a few testhelpers.
One test now fails, which is disabled for now until the operator forwarder team can address this test
cannot call functions on the LINK token through callbacks