Remove Solidity 0.6 & 0.7 code #12578
Conversation
|
I see you updated files related to |
|
I see you updated files related to |
| @@ -26,15 +26,14 @@ jobs: | |||
| - 'contracts/**/*' | |||
| - '.github/workflows/solidity.yml' | |||
| - '.github/workflows/solidity-foundry.yml' | |||
| old_sol: | |||
There was a problem hiding this comment.
Afaik @smartcontractkit/keepers has some frozen code that should be included here so I'll keep this logic around. I've added the deprecated interface folder here for now, as no files should be added there
core/scripts/vrfv1/README.md
Outdated
| [VRF Coordinator](../../../contracts/src/v0.6/VRFCoordinator.sol), using the | ||
| [VRF Coordinator](../../../contracts/src/v0.8/vrf/VRFCoordinatorV2.sol), using the |
There was a problem hiding this comment.
This is a misleading link, maybe link to https://github.com/smartcontractkit/chainlink-contracts-deprecated/blob/main/contracts/src/v0.6/VRFCoordinator.sol instead since its the right contract?
contracts/test/v0.8/VRFD20.test.ts
Outdated
There was a problem hiding this comment.
I think this can be axed, it seems to be a VRF V1 consumer, not V2 or V2.5.
There was a problem hiding this comment.
Can axe this, this is VRF v1. Not even sure how this is working after you axed all the V1 contracts?
Removed in #12569 |
|
@jinhoonbang they are already gone ;) |
# Conflicts: # core/gethwrappers/generation/generated-wrapper-dependency-versions-do-not-edit.txt
RensR
dismissed stale reviews from erikburt, jinhoonbang, and jmank88
via
64581d9
|
This PR removes all Solidity source code that isn't >=0.8.x
Since 0.6 and 0.7 do have gethwrappers, we keep the wrappers themselves around, but we remove the generation commands.