Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalizer fix #15457

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Finalizer fix #15457

merged 2 commits into from
Dec 3, 2024

Conversation

dimriou
Copy link
Collaborator

@dimriou dimriou commented Nov 29, 2024 •
edited by jira bot
Loading

@dimriou dimriou requested review from a team as code owners November 29, 2024 11:04
mateusz-sekara
mateusz-sekara approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@mateusz-sekara mateusz-sekara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some unit test for that?

@dimriou dimriou added this pull request to the merge queue Dec 2, 2024
@dimriou dimriou removed this pull request from the merge queue due to a manual request Dec 2, 2024
@dimriou dimriou added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@dimriou dimriou added this pull request to the merge queue Dec 3, 2024
Merged via the queue into develop with commit f6dfb4e Dec 3, 2024
153 of 154 checks passed
@dimriou dimriou deleted the finalizer_fix branch December 3, 2024 11:23
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Draft
dimriou added a commit that referenced this pull request Dec 9, 2024
@dimriou
Finalizer fix (#15457)
d214dc8 
* Finalizer fix

* Add changeset
Bwest981 pushed a commit that referenced this pull request Dec 9, 2024
@dimriou
Finalizer fix (#15457) (#15577)
6da84b2 
* Finalizer fix

* Add changeset
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Draft
github-merge-queue bot pushed a commit that referenced this pull request Jan 3, 2025
@Bwest981 @bolekk
@cedric-cordenier @jmank88 @patrickhuie19 @dimriou @chainchad
Merge release/2.19.0 to develop (#15824)
42d02c2 
* Bump version and update CHANGELOG for core v2.19.0

Signed-off-by: bwest981 <[email protected]>

* [Keystone] Disable remote calls to RegisterToWorkflow (#15352)

* [Keystone] Disable remote calls to RegisterToWorkflow

* Remove failing test

---------

Co-authored-by: Cedric Cordenier <[email protected]>

* [KS-490] Support per-step timeout overrides in the Engine (#15367)

* testdata/scripts/nodes/evm/list: add test; common/client: fix names in multinode state map [v2.19] (#15372)

(cherry picked from commit 0cabe54)

Co-authored-by: Brandon West <[email protected]>

* Consume latest changeset and update changelog (#15431)

* Consume latest changeset and update changelog

* Update CHANGELOG.md

* bumping wsrpc (#15549) (#15550)

* bumping wsrpc (#15549)

* Update go.mod

* make gomodtidy

---------

Co-authored-by: Patrick <[email protected]>

* Finalizer fix (#15457) (#15577)

* Finalizer fix

* Add changeset

* Update changeset to include clearing txs bugfix (#15578)

* Finalize date on changelog for 2.19.0 (#15670)

Signed-off-by: bwest981 <[email protected]>

---------

Signed-off-by: bwest981 <[email protected]>
Co-authored-by: Bolek <[email protected]>
Co-authored-by: Cedric Cordenier <[email protected]>
Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Patrick <[email protected]>
Co-authored-by: Dimitris Grigoriou <[email protected]>
Co-authored-by: chainchad <[email protected]>
joaoluisam pushed a commit that referenced this pull request Jan 9, 2025
@Bwest981 @bolekk
@cedric-cordenier @jmank88 @patrickhuie19 @dimriou @chainchad @joaoluisam
Merge release/2.19.0 to develop (#15824)
369c68b 
* Bump version and update CHANGELOG for core v2.19.0

Signed-off-by: bwest981 <[email protected]>

* [Keystone] Disable remote calls to RegisterToWorkflow (#15352)

* [Keystone] Disable remote calls to RegisterToWorkflow

* Remove failing test

---------

Co-authored-by: Cedric Cordenier <[email protected]>

* [KS-490] Support per-step timeout overrides in the Engine (#15367)

* testdata/scripts/nodes/evm/list: add test; common/client: fix names in multinode state map [v2.19] (#15372)

(cherry picked from commit 0cabe54)

Co-authored-by: Brandon West <[email protected]>

* Consume latest changeset and update changelog (#15431)

* Consume latest changeset and update changelog

* Update CHANGELOG.md

* bumping wsrpc (#15549) (#15550)

* bumping wsrpc (#15549)

* Update go.mod

* make gomodtidy

---------

Co-authored-by: Patrick <[email protected]>

* Finalizer fix (#15457) (#15577)

* Finalizer fix

* Add changeset

* Update changeset to include clearing txs bugfix (#15578)

* Finalize date on changelog for 2.19.0 (#15670)

Signed-off-by: bwest981 <[email protected]>

---------

Signed-off-by: bwest981 <[email protected]>
Co-authored-by: Bolek <[email protected]>
Co-authored-by: Cedric Cordenier <[email protected]>
Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Patrick <[email protected]>
Co-authored-by: Dimitris Grigoriou <[email protected]>
Co-authored-by: chainchad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin approved these changes

@mateusz-sekara mateusz-sekara mateusz-sekara approved these changes

@huangzhen1997 huangzhen1997 huangzhen1997 approved these changes

@jmank88 jmank88 jmank88 approved these changes

@george-dorin george-dorin Awaiting requested review from george-dorin george-dorin is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimriou @jmank88 @huangzhen1997 @mateusz-sekara @amit-momin