Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumping wsrpc (#15549) #15550

Merged
merged 3 commits into from
Dec 8, 2024
Merged

bumping wsrpc (#15549) #15550

merged 3 commits into from
Dec 8, 2024

Conversation

Bwest981
Copy link
Collaborator

@Bwest981 Bwest981 commented Dec 6, 2024

No description provided.

@Bwest981 Bwest981 requested review from a team as code owners December 6, 2024 20:04
@Bwest981 Bwest981 requested review from patrickhuie19 and removed request for a team December 6, 2024 20:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

chainchad
chainchad previously approved these changes Dec 6, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

chainchad
chainchad reviewed Dec 6, 2024
View reviewed changes
core/scripts/go.mod Outdated
Comment on lines 425 to 426
github.com/soheilhy/cmux v0.1.5 // indirect
github.com/sony/gobreaker v0.5.0 // indirect
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe to remove?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, added it back in just in case; was part of a merge conflict from develop.

patrickhuie19
patrickhuie19 previously approved these changes Dec 6, 2024
View reviewed changes
patrickhuie19
patrickhuie19 reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@patrickhuie19 patrickhuie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make gomodtidy needs to be run again 🙏

@Bwest981 Bwest981 dismissed stale reviews from patrickhuie19 and chainchad via 7f101d0 December 6, 2024 21:52
@patrickhuie19 patrickhuie19 merged commit d6c3c4c into release/2.19.0 Dec 8, 2024
145 of 147 checks passed
@patrickhuie19 patrickhuie19 deleted the chore/release/2.19.0/add-more-changes branch December 8, 2024 04:41
github-merge-queue bot pushed a commit that referenced this pull request Jan 3, 2025
@Bwest981 @bolekk
@cedric-cordenier @jmank88 @patrickhuie19 @dimriou @chainchad
Merge release/2.19.0 to develop (#15824)
42d02c2 
* Bump version and update CHANGELOG for core v2.19.0

Signed-off-by: bwest981 <[email protected]>

* [Keystone] Disable remote calls to RegisterToWorkflow (#15352)

* [Keystone] Disable remote calls to RegisterToWorkflow

* Remove failing test

---------

Co-authored-by: Cedric Cordenier <[email protected]>

* [KS-490] Support per-step timeout overrides in the Engine (#15367)

* testdata/scripts/nodes/evm/list: add test; common/client: fix names in multinode state map [v2.19] (#15372)

(cherry picked from commit 0cabe54)

Co-authored-by: Brandon West <[email protected]>

* Consume latest changeset and update changelog (#15431)

* Consume latest changeset and update changelog

* Update CHANGELOG.md

* bumping wsrpc (#15549) (#15550)

* bumping wsrpc (#15549)

* Update go.mod

* make gomodtidy

---------

Co-authored-by: Patrick <[email protected]>

* Finalizer fix (#15457) (#15577)

* Finalizer fix

* Add changeset

* Update changeset to include clearing txs bugfix (#15578)

* Finalize date on changelog for 2.19.0 (#15670)

Signed-off-by: bwest981 <[email protected]>

---------

Signed-off-by: bwest981 <[email protected]>
Co-authored-by: Bolek <[email protected]>
Co-authored-by: Cedric Cordenier <[email protected]>
Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Patrick <[email protected]>
Co-authored-by: Dimitris Grigoriou <[email protected]>
Co-authored-by: chainchad <[email protected]>
joaoluisam pushed a commit that referenced this pull request Jan 9, 2025
@Bwest981 @bolekk
@cedric-cordenier @jmank88 @patrickhuie19 @dimriou @chainchad @joaoluisam
Merge release/2.19.0 to develop (#15824)
369c68b 
* Bump version and update CHANGELOG for core v2.19.0

Signed-off-by: bwest981 <[email protected]>

* [Keystone] Disable remote calls to RegisterToWorkflow (#15352)

* [Keystone] Disable remote calls to RegisterToWorkflow

* Remove failing test

---------

Co-authored-by: Cedric Cordenier <[email protected]>

* [KS-490] Support per-step timeout overrides in the Engine (#15367)

* testdata/scripts/nodes/evm/list: add test; common/client: fix names in multinode state map [v2.19] (#15372)

(cherry picked from commit 0cabe54)

Co-authored-by: Brandon West <[email protected]>

* Consume latest changeset and update changelog (#15431)

* Consume latest changeset and update changelog

* Update CHANGELOG.md

* bumping wsrpc (#15549) (#15550)

* bumping wsrpc (#15549)

* Update go.mod

* make gomodtidy

---------

Co-authored-by: Patrick <[email protected]>

* Finalizer fix (#15457) (#15577)

* Finalizer fix

* Add changeset

* Update changeset to include clearing txs bugfix (#15578)

* Finalize date on changelog for 2.19.0 (#15670)

Signed-off-by: bwest981 <[email protected]>

---------

Signed-off-by: bwest981 <[email protected]>
Co-authored-by: Bolek <[email protected]>
Co-authored-by: Cedric Cordenier <[email protected]>
Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: Patrick <[email protected]>
Co-authored-by: Dimitris Grigoriou <[email protected]>
Co-authored-by: chainchad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainchad chainchad chainchad left review comments

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bwest981 @patrickhuie19 @chainchad