Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling format on integers #1904

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Aug 2, 2023

Fixes: #1899

This PR adds a configuration option, disableIntegerFormat, which removes the format property which is set when integer types are enabled with useIntegerType.

API Gateway does not support int32 or int64 formats on numbers as noted in API Gateway Known Issues:

Numbers of the Int32 or Int64 type are not supported.

These formats are disabled by default for API Gateway conversions, but are otherwise enabled when using the useIntegerType configuration.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srchase srchase requested a review from a team as a code owner August 2, 2023 18:16
@srchase srchase merged commit 4009ad6 into smithy-lang:main Aug 2, 2023
@srchase srchase deleted the disable_int_format branch August 2, 2023 18:29
syall pushed a commit to Xtansia/smithy that referenced this pull request Aug 11, 2023
alextwoods pushed a commit to alextwoods/smithy that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smithy build OpenAPI outputs format incompatible with API Gateway
2 participants