-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-715551: Support authentication with OKTA #799
base: master
Are you sure you want to change the base?
Conversation
sfc-gh-ext-simba-jy
commented
Dec 17, 2024
•
edited
Loading
edited
- Implemented Okta authentication.
- Unit testing for authentication was added.
- Manual testing for authentication was added.
Co-authored-by: sfc-gh-ext-simba-hx <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #799 +/- ##
==========================================
- Coverage 80.52% 78.39% -2.14%
==========================================
Files 104 107 +3
Lines 9223 9484 +261
==========================================
+ Hits 7427 7435 +8
- Misses 1796 2049 +253 ☔ View full report in Codecov by Sentry. |
Hi @sfc-gh-ext-simba-jy there are some okta unit test errors |
I fixed the error. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performed manual tests and it looks good