Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-715551: Support authentication with OKTA #799

Open
wants to merge 95 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Dec 17, 2024

  • Implemented Okta authentication.
  • Unit testing for authentication was added.
  • Manual testing for authentication was added.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 65.78073% with 103 lines in your changes missing coverage. Please review.

Project coverage is 78.39%. Comparing base (9f9d51d) to head (1c9842a).

Files with missing lines Patch % Lines
cpp/lib/Authenticator.cpp 56.92% 56 Missing ⚠️
cpp/util/entities.cpp 49.12% 29 Missing ⚠️
cpp/lib/SnowflakeUtil.cpp 82.60% 4 Missing ⚠️
include/snowflake/IAuth.hpp 0.00% 4 Missing ⚠️
cpp/lib/IAuth.cpp 95.89% 3 Missing ⚠️
lib/client.c 40.00% 3 Missing ⚠️
lib/connection.c 40.00% 3 Missing ⚠️
lib/http_perform.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   80.52%   78.39%   -2.14%     
==========================================
  Files         104      107       +3     
  Lines        9223     9484     +261     
==========================================
+ Hits         7427     7435       +8     
- Misses       1796     2049     +253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dprzybysz
Copy link
Collaborator

Hi @sfc-gh-ext-simba-jy there are some okta unit test errors
the test_crud errors should be fixed in a separate PR

@sfc-gh-ext-simba-jy
Copy link
Collaborator Author

Hi @sfc-gh-ext-simba-jy there are some okta unit test errors the test_crud errors should be fixed in a separate PR

I fixed the error. Thank you!

Copy link
Contributor

@sfc-gh-mkubik sfc-gh-mkubik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed manual tests and it looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants