Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import of non-published NSDictionary helpers from SnowplowTracker on iOS #161

Closed
matus-tomlein opened this issue Apr 11, 2022 · 0 comments
Closed

Fix import of non-published NSDictionary helpers from SnowplowTracker on iOS #161

matus-tomlein opened this issue Apr 11, 2022 · 0 comments
Assignees
@matus-tomlein
Labels
priority:high To fix as soon as possible. type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Milestone
Version 1.2.1

Comments

@matus-tomlein
Copy link
Contributor

The RN tracker imports a non-exported file, NSDictionary+SP_TypeMethods.h from the iOS SnowplowTracker. The problem only shows up when use_frameworks! :linkage => :static is used in the Podfile.

The import should be removed and used methods included in the RN tracker.
@matus-tomlein matus-tomlein self-assigned this Apr 11, 2022
@matus-tomlein matus-tomlein added this to the Version 1.2.1 milestone Apr 11, 2022
@matus-tomlein matus-tomlein added type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. priority:high To fix as soon as possible. labels Apr 11, 2022
matus-tomlein added a commit that referenced this issue Apr 11, 2022
@matus-tomlein
Fix import of non-published NSDictionary helpers from SnowplowTracker…
611b110 
… on iOS (close #161)
matus-tomlein added a commit that referenced this issue Apr 11, 2022
@matus-tomlein
Fix import of non-published NSDictionary helpers from SnowplowTracker…
e3b6a17 
… on iOS (close #161)
matus-tomlein added a commit that referenced this issue Apr 11, 2022
@matus-tomlein
Fix import of non-published NSDictionary helpers from SnowplowTracker…
eea0316 
… on iOS (close #161)
@matus-tomlein matus-tomlein mentioned this issue Apr 11, 2022
Merged
@matus-tomlein matus-tomlein mentioned this issue Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matus-tomlein matus-tomlein

Labels
priority:high To fix as soon as possible. type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Milestone
Version 1.2.1
Development

No branches or pull requests
1 participant
@matus-tomlein