Fix import of non-published NSDictionary helpers from SnowplowTracker on iOS (close #161) #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matus-tomlein
force-pushed
the
issue/161-fix_import
branch
from
611b110 to
e3b6a17
Compare
matus-tomlein
force-pushed
the
issue/161-fix_import
branch
from
e3b6a17 to
eea0316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #161 and removes imports of internal header files (
NSDictinoary+SP_TypeMethods.handSPUtilities.h) from React Native tracker ObjC code.I added a
NSDictionary-RNSP_TypeMethodsheader and implementation to the RN tracker with the methods that were used. I changed the prefix of the file and methods since they conflicted with the original ones.Also added a
use_frameworks! :linkage => :staticdirective to the Podfile in DemoAppTV which raises errors in case this happens. I didn't add it to the DemoApp project because that uses Flipper and is not compatible with it. But we should be notified of such issues in the future when building the DemoAppTV project.