Skip to content

Commit

Permalink
fix bugs wich unnecessarily filters out snyk code issues (#206)
Browse files Browse the repository at this point in the history
minor: stop excluding code issues from being considered fixable

Fix excluding Snyk Code issues when using ifUpgradeAvailableOnly=true or ifAutoFixableOnly=true

All Snyk Code issues are fixable by rewriting code
  • Loading branch information
olegshprengelsnyk authored and lili2311 committed Oct 18, 2023
1 parent 9594f60 commit b1c560d
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions jira.go
Original file line number Diff line number Diff line change
Expand Up @@ -248,14 +248,18 @@ func openJiraTickets(flags flags, projectInfo jsn.Json, vulnsForJira map[string]

for _, vulnForJira := range vulnsForJira {
jsonVuln, _ := jsn.NewJson(vulnForJira)

// determine if is code issue
issueType := jsonVuln.K("data").K("attributes").K("issueType").String().Value
isCodeIssue := strings.Contains(issueType, "code")
// skip ticket creating if the vuln is not upgradable
if flags.optionalFlags.ifUpgradeAvailableOnly {
if flags.optionalFlags.ifUpgradeAvailableOnly && isCodeIssue == false {
if jsonVuln.K("fixInfo").K("isUpgradable").Bool().Value == false {
message := fmt.Sprintf("Skipping creating ticket for %s because no upgrade is available.", jsonVuln.K("issueData").K("title").String().Value)
fullListNotCreatedIssue += displayErrorForIssue(vulnForJira, "ifUpgradeAvailableOnly", errors.New(message), "", customDebug)
continue
}
} else if flags.optionalFlags.ifAutoFixableOnly {
} else if flags.optionalFlags.ifAutoFixableOnly && isCodeIssue == false {
// skip ticket creating if the vuln is not fixable
if jsonVuln.K("fixInfo").K("isFixable").Bool().Value == false {
message := fmt.Sprintf("Skipping creating ticket for %s because no fix is available.", jsonVuln.K("issueData").K("title").String().Value)
Expand Down

0 comments on commit b1c560d

Please sign in to comment.