Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs wich unnecessarily filters out snyk code issues #206

Merged

Conversation

olegshprengelsnyk
Copy link
Contributor

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

fix Jira Tickets for New Vulns bugs wich unnecessarily filters out snyk code issues when using either flag:

ifUpgradeAvailableOnly=true

ifAutoFixableOnly=true

Notes for the reviewer

Instructions on how to run this locally, background context, what to review, questions…

More information

Screenshots

Visuals that may help the reviewer

@olegshprengelsnyk olegshprengelsnyk requested a review from a team as a code owner October 18, 2023 00:48
Fix excluding Snyk Code issues when using ifUpgradeAvailableOnly=true or ifAutoFixableOnly=true

All Snyk Code issues are fixable by rewriting code
@lili2311 lili2311 force-pushed the fix/upgrade-and-fixability-filters-remove-code-tickets branch from bc5f2fc to 8e481fc Compare October 18, 2023 07:11
@lili2311 lili2311 merged commit 14c1970 into develop Oct 18, 2023
@lili2311 lili2311 deleted the fix/upgrade-and-fixability-filters-remove-code-tickets branch October 18, 2023 07:40
lili2311 pushed a commit that referenced this pull request Oct 18, 2023
minor: stop excluding code issues from being considered fixable

Fix excluding Snyk Code issues when using ifUpgradeAvailableOnly=true or ifAutoFixableOnly=true

All Snyk Code issues are fixable by rewriting code
aarlaud added a commit that referenced this pull request Jun 27, 2024
* fix bugs wich unnecessarily filters out snyk code issues (#206)

minor: stop excluding code issues from being considered fixable

Fix excluding Snyk Code issues when using ifUpgradeAvailableOnly=true or ifAutoFixableOnly=true

All Snyk Code issues are fixable by rewriting code

* Fixing dueDate to duedate (#216)

* minor: #211/snyk WAF error handling and sanitizing (#214)

* minor: sanitizing summary to prevent WAF failure

* minor: add custom errors for 403 http error when encountering WAF failure

* Update utils.go (#210)

Implement changes: Correct assigneeId data type issue, from Int to String

* minor: #212/print errors in writeErrorFile when not found (#213)

minor: print error messages for errorsfiles not found

* major: release fixes+improvements with assigneeId breaking change (#219)

---------

Co-authored-by: olegshprengelsnyk <[email protected]>
Co-authored-by: Arya Shajpaul <[email protected]>
Co-authored-by: Christoffer <[email protected]>
Co-authored-by: Kuldeep Thakre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants