Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internal usage of NodeItem with AddrPort #348

Closed
gavin-norman-sociomantic opened this issue Jul 27, 2018 · 2 comments
Closed

Replace internal usage of NodeItem with AddrPort #348

gavin-norman-sociomantic opened this issue Jul 27, 2018 · 2 comments
Labels
type-refactoring
Milestone
Ideas / future

Comments

@gavin-norman-sociomantic
Copy link

A mix of the two structs is used internally, which is really inconvenient.
@gavin-norman-sociomantic gavin-norman-sociomantic added this to the v4.8.0 milestone Jul 27, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/swarm that referenced this issue Jul 27, 2018
Add methods to set AddrPort from NodeItem and convert back
cf8facc 
As part of replacing internal usages of NodeItem with AddrPort, it's useful
to have a convenient way of converting from one to the other.

Part of sociomantic-tsunami#348.
Closed
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/swarm that referenced this issue Aug 2, 2018
Add methods to set AddrPort from NodeItem and convert back
88dc640 
As part of replacing internal usages of NodeItem with AddrPort, it's useful
to have a convenient way of converting from one to the other.

Part of sociomantic-tsunami#348.
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/swarm that referenced this issue Aug 8, 2018
Add methods to set AddrPort from NodeItem and convert back
42066da 
As part of replacing internal usages of NodeItem with AddrPort, it's useful
to have a convenient way of converting from one to the other.

Part of sociomantic-tsunami#348.
Merged
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/swarm that referenced this issue Aug 14, 2018
Add methods to set AddrPort from NodeItem and convert back
db4b6c8 
As part of replacing internal usages of NodeItem with AddrPort, it's useful
to have a convenient way of converting from one to the other.

Part of sociomantic-tsunami#348.
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/swarm that referenced this issue Aug 20, 2018
Add methods to set AddrPort from NodeItem and convert back
0fc807a 
As part of replacing internal usages of NodeItem with AddrPort, it's useful
to have a convenient way of converting from one to the other.

Part of sociomantic-tsunami#348.
@gavin-norman-sociomantic
Copy link
Author

This is a big task. #353 scratches the surface.

I think we should delay this and do it as part of #57. It's not worth trying to unravel things right now.

gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/swarm that referenced this issue Aug 22, 2018
Add methods to set AddrPort from NodeItem and convert back
63350fd 
As part of replacing internal usages of NodeItem with AddrPort, it's useful
to have a convenient way of converting from one to the other.

Part of sociomantic-tsunami#348.
nemanja-boric-sociomantic pushed a commit that referenced this issue Aug 22, 2018
@nemanja-boric-sociomantic
Add methods to set AddrPort from NodeItem and convert back
225bfb8 
As part of replacing internal usages of NodeItem with AddrPort, it's useful
to have a convenient way of converting from one to the other.

Part of #348.
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/swarm that referenced this issue Aug 23, 2018
Add methods to set AddrPort from NodeItem and convert back
2d6937e 
As part of replacing internal usages of NodeItem with AddrPort, it's useful
to have a convenient way of converting from one to the other.

Part of sociomantic-tsunami#348.
@gavin-norman-sociomantic
Copy link
Author

I think we should delay this and do it as part of #57. It's not worth trying to unravel things right now.

Me in December agrees with me in August. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-refactoring
Projects
None yet
Milestone
Ideas / future
Development

No branches or pull requests
1 participant
@gavin-norman-sociomantic