Change use of NodeItem to AddrPort in node base classes #350
Conversation
|
Note to reviewer: could you confirm the changes around |
|
(I was originally intending to replace all internal usage of |
|
Blocked pending testing with proto and node repos. |
| @@ -38,9 +39,20 @@ public interface INodeInfo | |||
|
|
|||
| **************************************************************************/ | |||
|
|
|||
| deprecated("Use addr_port instead") | |||
| public NodeItem node_item ( ); | |||
There was a problem hiding this comment.
Deprecation node?
There was a problem hiding this comment.
Could you elaborate?
|
|
||
| **************************************************************************/ | ||
|
|
||
| public AddrPort addr_port ( ); |
There was a problem hiding this comment.
Breaking change?
| @@ -845,13 +891,18 @@ public class NodeBase ( ConnHandler : ISwarmConnectionHandler ) : INodeBase | |||
| } | |||
|
|
|||
| // Super ctor. | |||
| InetAddress!(false) addr, neo_addr; | |||
| addr = cast(sockaddr_in)node; | |||
There was a problem hiding this comment.
Consider adding opCast from AddrPort directly to InetAddr.
| super(node, conn_setup_params, | ||
| this.listener = new Listener( | ||
| addr(node.Address, node.Port), this.socket, conn_setup_params, | ||
| cast(sockaddr*)&addr.addr, this.socket, conn_setup_params, |
There was a problem hiding this comment.
This is fine, considering that addr.addr is sockaddr_in. However, I think by casting pointer we're loosing the type safety here. I would just add the static assert before static assert(typeof(addr.addr) is sockaddr_in).
As part of replacing internal usages of NodeItem with AddrPort, it's useful to have a convenient way of converting from one to the other. Part of sociomantic-tsunami#348.
This tests that all expected base class and interface methods are implemented, not merely that the code is syntactically correct.
gavin-norman-sociomantic
force-pushed
the
nodeitem
branch
from
8945a7f to
05262d3
Compare
No description provided.