Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle URLs properly #93

Closed
hgcummings opened this issue Jan 22, 2016 · 4 comments
Closed

Handle URLs properly #93

hgcummings opened this issue Jan 22, 2016 · 4 comments

Comments

@hgcummings
Copy link
Contributor

The [https://github.com/NodeRedis/node_redis](Node.js redis client) supports (and explicitly documents) fully-specified URLs, i.e. [redis:]//[user][:password@][host][:port][/db-number][?db=db-number[&password=bar[&option=value]]].

The socket.io-redis adaptor can only handle URLs of the form hostname:port.

hgcummings added a commit to hgcummings/socket.io-redis that referenced this issue Jan 26, 2016
@hunterloftis
Copy link

I'd love to see your patch merged in.

@hgcummings
Copy link
Contributor Author

Thanks! The patch above is waiting for merge on PR #94. Hopefully someone can get to it soon.

@portepa
Copy link

portepa commented Apr 11, 2016

That would be cool to see this patch merged.
Thanks @hgcummings for this fix.

@hgcummings
Copy link
Contributor Author

Any chance of any movement on this? - It's becoming more inconvenient for me and I was hoping my PR would have been merged by now. Or is this blocked on issue #75?

Please let me know if there's anything I can do to help get the PR merged.

@rauchg rauchg closed this as completed in 298e06b May 10, 2016
rauchg added a commit that referenced this issue May 10, 2016
Fixes #93 by passing full URI to redis.createClient when specified
@darrachequesne darrachequesne modified the milestone: 1.1.0 Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants